Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix partial index where clause csc2 parser #223

Merged
merged 1 commit into from
Jul 18, 2017
Merged

fix partial index where clause csc2 parser #223

merged 1 commit into from
Jul 18, 2017

Conversation

ldennis
Copy link
Contributor

@ldennis ldennis commented Jul 11, 2017

  • Use regexp to match where clause in csc2:
dqstring \"(\\.|[^\n\\\"])*\"
sqstring \'(\\.|[^\n\\\'])*\'
where [{][\t ]*[Ww][Hh][Ee][Rr][Ee][\t ]({sqstring}|{dqstring}|[^}\"\'])*[\t ]*[}]

roborivers
roborivers reviewed Jul 11, 2017
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Regression testing: 1/116 tests failed.

The first 10 failing tests are:
analyze

Detail | Logs

@ldennis
Copy link
Contributor Author

ldennis commented Jul 18, 2017

This only affects partial indexes parsing. I am merging this in and closing the related issue.

@ldennis ldennis merged commit 966300c into bloomberg:master Jul 18, 2017
@ldennis ldennis deleted the partidx_csc2 branch August 16, 2017 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roborivers roborivers roborivers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSC2: Partial index needs to be defined on a separate line
2 participants
@ldennis @roborivers