Remove WSL from README #2381
Merged
Remove WSL from README #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverszhang89
commented
Aug 2, 2020
| @@ -30,7 +30,7 @@ On every machine in the cluster: | |||
|
|
|||
| 2. Install prerequisites: | |||
|
|
|||
| **Ubuntu 16.04, 16.10, 17.04, Windows Subsystem for Linux (WSL)** | |||
| **Debian/Ubuntu** | |||
There was a problem hiding this comment.
I'm removing WSL from the README file. WSL now supports various distributions including opensuse and fedora. WSL users should use their distribution's package manager to install the dependencies.
roborivers
suggested changes
Aug 2, 2020
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠ .
Regression testing: Success ✓.
roborivers
reviewed
Aug 3, 2020
There was a problem hiding this comment.
Sysbench Transactions Per Second (commit: 3ac5190):
@@ sysbench/select_random_points @@
failed
@@ sysbench/select_random_ranges @@
+11.74%
@@ sysbench/oltp_update_index @@
-7.82%
@@ sysbench/oltp_write_only @@
-4.44%
Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unix Socket on Windows 10 doesn't support
SO_KEEPALIVE.evconnlistener_new_bind()skipsSO_KEEPALIVEif_WIN32is define. However on WSL the macro isn't predefined.To work it around, we create a socket on our own, attempt to set
KEEPALIVEon it but do not bail out if failed, and pass it toevconnlistener_new()to listen on.Fixes #2290.