-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the auto-consume logic in cdb2_close #3362
Conversation
cdb2_close() attempts to drain unfetched rows in order to make the connection reusable for the next sockpool user. This logic however may undesirably consume events from a consumer. Disable it by default. Fixes bloomberg#3361. Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 9/440 tests failed ⚠.
The first 10 failing tests are:
sc_downgrade [core dumped]
socksql_master_swings
sc_truncate
phys_rep
ignore_bad_table
weighted_standing_queue
load_cache_dumpmax_generated
load_cache_autocache_generated
cdb2_close
sc_downgrade
I was thinking it might be better to simply track if |
Also need to patch |
bb-cdb2api does not have auto-consume in
This is insufficient, as user might have called |
Yes you're right. We need to patch these places for a mixed use of 'exec procedure' on a consumer and regular queries. |
Let us disable for now - we can make it robust later. |
Auto-consume needs to be enabled for this test to pass (it was disabled in bloomberg#3362). Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
Auto-consume needs to be enabled for this test to pass (it was disabled in #3362). Signed-off-by: Rivers Zhang <hzhang320@bloomberg.net>
cdb2_close() attempts to drain unfetched rows in order to make the connection reusable for the next sockpool user. This logic however may undesirably consume events from a consumer. Disable it by default.
Fixes #3361.