Duplicate code in Boa

[0x7D2B]

I've been coming across a lot of duplicate or very similar code in Boa. I think a lot of it can be combined to simplify things. Some examples:

Function parsers

There are four very similar parsers for function declarations and statements, one for each combination of async/non-async function expression/declaration:

• boa/boa/src/syntax/parser/expression/primary/function_expression/mod.rs

  Line 45 in 586a689

  fn parse(self, cursor: &mut Cursor<R>) -> Result<Self::Output, ParseError> {

• boa/boa/src/syntax/parser/expression/primary/async_function_expression/mod.rs

  Line 50 in 586a689

  fn parse(self, cursor: &mut Cursor<R>) -> Result<Self::Output, ParseError> {

• boa/boa/src/syntax/parser/statement/declaration/hoistable/function_decl/mod.rs

  Line 51 in 586a689

  fn parse(self, cursor: &mut Cursor<R>) -> Result<Self::Output, ParseError> {

• boa/boa/src/syntax/parser/statement/declaration/hoistable/async_function_decl/mod.rs

  Line 51 in 586a689

  fn parse(self, cursor: &mut Cursor<R>) -> Result<Self::Output, ParseError> {

For reference, here's also the arrow function parser:

• boa/boa/src/syntax/parser/expression/assignment/arrow_function.rs

  Line 71 in e2f9ecd

  fn parse(self, cursor: &mut Cursor<R>) -> Result<Self::Output, ParseError> {

Function AST nodes

• boa/boa/src/syntax/ast/node/declaration/function_decl/mod.rs

  Line 40 in 39764b9

  impl FunctionDecl {

• boa/boa/src/syntax/ast/node/declaration/function_expr/mod.rs

  Line 37 in 39764b9

  impl FunctionExpr {

• boa/boa/src/syntax/ast/node/declaration/async_function_decl/mod.rs

  Line 30 in 39764b9

  impl AsyncFunctionDecl {

• boa/boa/src/syntax/ast/node/declaration/async_function_expr/mod.rs

  Line 31 in 39764b9

  impl AsyncFunctionExpr {

• boa/boa/src/syntax/ast/node/declaration/arrow_function_decl/mod.rs

  Line 33 in 39764b9

  impl ArrowFunctionDecl {

Declarative and function environment records

Declarative and function environments are almost identical in their implementation. Fixed in #1156.

• boa/boa/src/environment/declarative_environment_record.rs

  Line 40 in 39764b9

  impl EnvironmentRecordTrait for DeclarativeEnvironmentRecord {

• boa/boa/src/environment/function_environment_record.rs

  Line 96 in 39764b9

  impl EnvironmentRecordTrait for FunctionEnvironmentRecord {

Loops

While and Do-While loops:

• https://github.com/boa-dev/boa/blob/39764b9e006ee51523edd3af55afe1833fda3c40/boa/src/syntax/ast/node/iteration/while_loop/mod.rs
• https://github.com/boa-dev/boa/blob/39764b9e006ee51523edd3af55afe1833fda3c40/boa/src/syntax/ast/node/iteration/do_while_loop/mod.rs

For-In and For-Of loops:

• boa/boa/src/syntax/ast/node/iteration/for_in_loop/mod.rs

  Line 94 in 39764b9

  loop {

• boa/boa/src/syntax/ast/node/iteration/for_of_loop/mod.rs

  Line 84 in 39764b9

  loop {

Fixed issues

Fixed

ConstDeclList, LetDeclList, VarDeclList and ConstDecl, LetDecl, VarDecl (Fixed in #1181)

Six declaration container objects which are almost identical.

• https://github.com/boa-dev/boa/blob/7b103a5c0bf29150a9bace87b17b39c9e0e7750d/boa/src/syntax/ast/node/declaration/const_decl_list/mod.rs
• https://github.com/boa-dev/boa/blob/7b103a5c0bf29150a9bace87b17b39c9e0e7750d/boa/src/syntax/ast/node/declaration/let_decl_list/mod.rs
• https://github.com/boa-dev/boa/blob/7b103a5c0bf29150a9bace87b17b39c9e0e7750d/boa/src/syntax/ast/node/declaration/var_decl_list/mod.rs

Function calls and object constructors (Fixed in #1273)

This already resulted in an issue where one of these implementations had a bug while the other had it fixed.

• boa/boa/src/object/gcobject.rs

  Line 118 in 39764b9

  pub fn call(&self, this: &Value, args: &[Value], context: &mut Context) -> Result<Value> {

• boa/boa/src/object/gcobject.rs

  Line 214 in 39764b9

  ) -> Result<Value> {

[0x7D2B]

#1273 fixes the function call and constructor one.

[jedel1043]

Closing since most of the deduplication was removed when we created the VM interpreter.