Youtube ads - Additional blocking rules

[lukemulks]

Follow up from: brave/browser-laptop#7230

I've run comparison checks against uBlock Origin, AdBlock Plus (with Acceptable Ads disabled), and Brave Shields. The data from the comparison checks is included in the following xlsx:
Youtube-blocking-comparison-02172017.xlsx

I ran some additional testing to see if I could apply any new rules in about:adblock , and with the following rules applied I am able to visibly see the video ads blocked for the first 7-10 segments I click on (the "Visit Advertiser's Site" overlay briefly shows up and then goes away quickly):

@@||google.com/jsapi$script,third-party
@@||youtube.com/api/stats/watchtime?$image,domain=youtube.com
||doubleclick.net^
=adunit&
||youtube.com/api/stats/ads?
||youtube.com/ptracking?
/generate_204$image
ad_html5&

The two exceptions applied above were observed in ABP and uBlock, which are likely in place to maintain compatibility with the video player.

However, after about 10-12 playback attempts, I'm seeing an ad appear. This is really strange. The blocking taking place initially matches what is working for users that aren't signed in.

Note: Ads are only observed while authenticated. Users that aren't signed are seeing ad blocking work as expected.

There are the following ELEMHIDE rules applied in both uBlock and ABP that I don't believe we are using:

##.ytp-ad-progress-list
##.video-ads 
youtube.com##.ad-container
###watch7-sidebar-ads
youtube.com###watch-channel-brand-div

I also attempted the isThirdPartyHost test we discussed (referenced in Slack), but I am not 100% confident I am testing that correctly.

Based on the calls that aren't blocked, I can't tell if we're just not blocking 1st party verbatim EasyList rules, or if I was testing isThirdPartyHost incorrectly, as I believe we should be seeing youtube.com requests that contain =adunit& blocked that I'm not seeing blocked in Brave (I am seeing them blocked in ABP & uBlock).

• I know there's some objection to css blocking, so it might be worth testing the third party host settings in case I was not testing that correctly.

• If that doesn't work, then css ELEMHIDE blocking for YT would likely be the next option.

• If neither of those work, I think there could be a larger problem.

• I noticed that uBlock is using EasyPrivacy, and that a lot of blocking was taking place from that list. If we're not using that, it might be worth exploring.

Thanks for the help here. This one has been a real pain.

[lukemulks]

@bbondy I made another sweep here just to make sure that things hadn't changed too much.

These are the following CSS selector/element hiding rules that ABP is using for Youtube that we currently don't block;

##.ad-div
##.masthead-ad-control
##.video-ads
###ad_creative_3
###footer-ads
###watch7-sidebar-ads
##.ytp-ad-progress-list
youtube.com##.ad-container
youtube.com###video-masthead
youtube.com###watch-channel-brand-div

These are the YT 1p calls, and filters that would work for blocking them:

=adunit&$xmlhttprequest,image

• https://www.youtube.com/get_video_info?html5=1&video_id=vIu0AjDvkz8&cpn=4W8VbmOUQB26UiPe&eurl&el=adunit&hl=en_US&agcid=168345827271&aqi=WSjLWLLSF862BsrUvvAC&sts=17240&lact=622&c=WEB&cver=1.20170315&cplayer=UNIPLAYER&cbr=Chrome&cbrver=56.0.2924.87&cos=Windows&cosver=10.0&adformat=15_2_1&iv_load_policy=1&autoplay=1&noiba=1&width=854&height=480&content_v=PhHtBqsGAoA&authuser=0&ei=WSjLWPP0C8HNugLszZ_YAg

• https://s.youtube.com/api/stats/qoe?event=streamingstats&cpn=4W8VbmOUQB26UiPe&el=adunit&docid=vIu0AjDvkz8&ns=yt&fexp=3300112%2C3300133%2C3300161%2C3312806%2C3313274%2C3313321%2C9407610%2C9419452%2C9422596%2C9428398%2C9431012%2C9433221%2C9434046%2C9434289%2C9445368%2C9446054%2C9446364%2C9449034%2C9449243%2C9450059%2C9451367%2C9451491%2C9456640%2C9457141%2C9457449%2C9458230%2C9458325%2C9460160%2C9460261%2C9461561%2C9461757%2C9462837%2C9463010%2C9463496%2C9463594%2C9463965%2C9464097%2C9464489%2C9465026%2C9465077%2C9465183%2C9465402%2C9465533%2C9465617%2C9466112%2C9466425%2C9466793%2C9466867%2C9467030%2C9467050%2C9467176%2C9467414&adformat=15_2_1&seq=1&c=WEB&cver=1.20170315&cplayer=UNIPLAYER&cbr=Chrome&cbrver=56.0.2924.87&cos=Windows&cosver=10.0&vps=0.032:N,0.045:B,0.085:ER&cmt=0.045:0.000,0.085:0.000,0.085:0.000&error=0.085:manifest.net.connect:0.000:backend.gvi;rc.0;rt.0.048&bh=0.085:0.000&bat=0.085:1:1&vis=0.085:0

/gen_204

• youtube-nocookie.com/gen_204

/player_204

• youtube.com/player_204

/csi_204

• youtube.com/csi_204

These are additional filters that blocked in ABP, we're using these already as far as I can tell, but am noting:

||doubleclick.net^$third-party,domain=youtube-nocookie.com|youtube.com
/securepubads.$script
/api/ads/*$script
||google.com/pagead/$image
/pagead2.$image,script
/pubads.$xmlhttprequest,subdocument
/googleads.$xmlhttprequest,image
/generate_204

I think that if we opened up to allow for 1p blocking, even if only for youtube.com - the issue at hand might remedy itself. That would probably be the best route we could take first.
If I can block strings from 1st parties, then we might also be able to block a lot of what ABP hits with their CSS selector rules without having to resort to CSS blocking.

• I took a look in Opera today, with ad blocking on, and they're blocking the vast majority of ads. However, they are probably letting 1/9 ads in from what I observed.

• ABP and AB are consistently blocking, uBO is as well, so I started with what rules they're using above.

• If you're able to just remove the 1p blocking restriction for YT.com (or for the browser - even if it's just for a test build or something along those lines) - I can handle the rest of the testing and see what has to get resolved. I'm just stuck at that part.