Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OS location service on macOS #10724

Closed
simonhong opened this issue Jul 14, 2020 · 8 comments
Closed

Support OS location service on macOS #10724

simonhong opened this issue Jul 14, 2020 · 8 comments
Assignees

Comments

@simonhong
Copy link
Member

simonhong commented Jul 14, 2020

Upstream already has CoreLocationProvider.
However, it doesn't work if Brave is not inserted in allowed list of Location Service.
If Brave is not inserted, we should use NetworkLocationProvider as a fallback

On Windows, if user doesn't enable OS location service, NetworkLocationProvider is set even if LocationProviderWinrt flag is on. However, NetworkLocationProvider is not used on macOS as a fallback.

STR:

  1. Check MacCoreLocationBackendStudy is enabled from brave://version
  2. Load https://www.gps-coordinates.net/my-location
  3. Allow location permission via site settings bubble below

Screen Shot 2021-07-29 at 10 24 34 AM

4. Allow Brave browser for accessing os location via `Preferences`

Screen Shot 2021-07-29 at 10 26 24 AM

5. Reload and check it shows correct location
@simonhong
Copy link
Member Author

It seems macOS support is in-progress and it's targeted to C86
Upstream issue - https://bugs.chromium.org/p/chromium/issues/detail?id=1051591
I think it's fine to wait upstream progress. WDYT? @bsclifton @rebron @fmarier

@bsclifton
Copy link
Member

@simonhong SGTM 👍

@bsclifton bsclifton added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Jul 14, 2020
@simonhong simonhong removed this from the 1.13.x - Beta milestone Aug 20, 2020
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Sep 4, 2020
@rebron rebron self-assigned this Oct 20, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 30, 2020

@rebron rebron closed this as completed Oct 30, 2020
@rebron rebron added this to the 1.18.x - Nightly milestone Oct 30, 2020
@rebron rebron reopened this Nov 18, 2020
@simonhong simonhong removed this from the 1.18.x - Beta milestone Nov 18, 2020
@rebron rebron removed their assignment Jan 25, 2021
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jul 12, 2021
@rebron
Copy link
Collaborator

rebron commented Jul 12, 2021

cc: @mihaiplesa @mkarolin

@simonhong
Copy link
Member Author

I think we can fix this by enabling Core Location Backend feature by default?

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 15, 2021
@rebron rebron changed the title [Desktop] Support OS location service on macOS Support OS location service on macOS Jul 19, 2021
@simonhong simonhong added this to the 1.27.x - Release #3 milestone Jul 29, 2021
@simonhong
Copy link
Member Author

simonhong commented Jul 29, 2021

Set 1.27.x milestone as MacCoreLocationBackendStudy is also applied to current release channel.
I can see MacCoreLocationBackendStudy is enabled via brave://version like below and can get accurate location.
STR is added in the description.
cc @kjozwiak @rebron

Screen Shot 2021-07-29 at 10 17 43 AM

@simonhong simonhong removed the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Jul 29, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Aug 4, 2021

Verified passed with

Brave | 1.27.110 Chromium: 92.0.4515.131 (Official Build) (x86_64)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | macOS Version 10.15.7 (Build 19H1217)

Confirmed MacCoreLocationBackendStudy:Enabled on brave://version.
Confirmed prompted to select location permission preference via site settings bubble.
Confirmed selecting Block button did not prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed selecting Allow button did prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed after allowing Brave Browser to use the macOS Location Services and refreshing the https://www.gps-coordinates.net/my-location page, the map showed my correct location.

Example Example Example
Screen Shot 2021-08-04 at 8 29 06 AM Screen Shot 2021-08-04 at 8 45 53 AM Screen Shot 2021-08-04 at 8 46 14 AM

Verified passed with

Brave	1.27.110 Chromium: 92.0.4515.131 (Official Build) (arm64)
Revision	6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS	macOS Version 11.5.1 (Build 20G80)

Confirmed MacCoreLocationBackendStudy:Enabled on brave://version.
Confirmed prompted to select location permission preference via site settings bubble.
Confirmed selecting Block button did not prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed selecting Allow button did prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed after allowing Brave Browser to use the macOS Location Services and refreshing the https://www.gps-coordinates.net/my-location page, the map showed my correct location.

Example Example Example
Screen Shot 2021-08-04 at 9 02 22 AM Screen Shot 2021-08-04 at 9 03 55 AM Screen Shot 2021-08-04 at 9 04 01 AM

Verified PASSED using

Brave 1.27.110 Chromium: 92.0.4515.131 (Official Build) (x86_64)
Revision 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS macOS Version 11.5.1 (Build 20G80)

Confirmed MacCoreLocationBackendStudy:Enabled on brave://version.
Confirmed prompted to select location permission preference via site settings bubble.
Confirmed selecting Block button did not prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed selecting Allow button did prompt me to allow Brave Browser to access OS location services via Preferences.
Confirmed after allowing Brave Browser to use the macOS Location Services and refreshing the https://www.gps-coordinates.net/my-location page, the map showed my correct location.

Example Example Example
Screen Shot 2021-08-04 at 8 21 37 AM Screen Shot 2021-08-04 at 8 22 28 AM Screen Shot 2021-08-04 at 8 23 00 AM

@kjozwiak
Copy link
Member

kjozwiak commented Aug 5, 2021

Going to exclude this from the notes as this already went out via Griffin. This was more of a double check to make sure things are working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants