-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OS location service on macOS #10724
Comments
It seems macOS support is in-progress and it's targeted to C86 |
@simonhong SGTM 👍 |
Possibly fixed with CR87 with https://chromium.googlesource.com/chromium/src.git/+/38a2229ca75e9cb1e1a17acc6c29027c302a0ba4 |
cc: @mihaiplesa @mkarolin |
I think we can fix this by enabling |
Verified passed with
Confirmed
Verified passed with
Confirmed
Verified
Confirmed
|
Going to exclude this from the notes as this already went out via Griffin. This was more of a double check to make sure things are working as expected. |
Upstream already has
CoreLocationProvider
.However, it doesn't work if Brave is not inserted in allowed list of Location Service.
If Brave is not inserted, we should use
NetworkLocationProvider
as a fallbackOn Windows, if user doesn't enable OS location service,
NetworkLocationProvider
is set even ifLocationProviderWinrt
flag is on. However,NetworkLocationProvider
is not used on macOS as a fallback.STR:
MacCoreLocationBackendStudy
is enabled from brave://version4. Allow Brave browser for accessing os location via `Preferences`
5. Reload and check it shows correct location
The text was updated successfully, but these errors were encountered: