Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style Search section in settings #1186

Closed
rebron opened this issue Sep 18, 2018 · 2 comments
Closed

style Search section in settings #1186

rebron opened this issue Sep 18, 2018 · 2 comments
Labels
closed/invalid feature/global-settings Settings at browser level independent of shields settings feature/search priority/P4 Planned work. We expect to get to it "soon".

Comments

@rebron
Copy link
Collaborator

rebron commented Sep 18, 2018 •
edited
Loading

Description

see Design spec
Style Search section with Brave styling
re-label section - 'Search'
re-label in sidebar - 'Search'

Relabel 'Search engine used in the address bar' to 'Default search engine'.
Keep 'Manage search engines' section but use Brave styling.

Design

screen shot 2018-10-03 at 1 18 06 pm
@rebron rebron added feature/global-settings Settings at browser level independent of shields settings browser-laptop-parity feature/search labels Sep 18, 2018
@rebron rebron added this to the 1.0 milestone Sep 18, 2018
This was referenced Sep 27, 2018
Closed
Closed
@rebron
Copy link
Collaborator Author

rebron commented Oct 3, 2018

separating out tasks and will file a separate issue for adding the private browsing options

@rebron rebron changed the title style Search in settings and Add private browsing options style Search in settings Oct 3, 2018
@bsclifton bsclifton mentioned this issue Oct 12, 2018
Closed
28 tasks
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed browser-laptop-parity labels Jan 15, 2019
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 17, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@petemill petemill changed the title style Search in settings style Search section in settings Mar 12, 2019
@rebron
Copy link
Collaborator Author

rebron commented Mar 13, 2019

Closing out per discussion with @rossmoody. "Search engine" and "Search engine used in the address bar" are better labels and more descriptive, and styling change will be applied from other work.

@rebron rebron closed this as completed Mar 13, 2019
@rebron rebron added this to the Dupe / Invalid / Not actionable milestone Mar 13, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid feature/global-settings Settings at browser level independent of shields settings feature/search priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @bsclifton @rebron