Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields shows blocked count even before a page is loaded #1206

Closed
srirambv opened this issue Sep 20, 2018 · 1 comment
Closed

Shields shows blocked count even before a page is loaded #1206

srirambv opened this issue Sep 20, 2018 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

Description

Shields shows blocked count even before a page is loaded

Steps to Reproduce

  1. Open a new tab
  2. Visit any site by entering the URL and press enter
  3. Even before the page is loaded, shields shows block count as 1 and is disabled and not clickable. Once page loads, it shows the correct blocked items

Actual result:

shieldbadge

Expected result:

Shields badge should show only after the page is loaded and it has blocked items

Reproduces how often:

100%

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @bbondy please reassign milestone to 0.55.x if needed. This is not a blocker hence added to 1.0 milestone
@brave/legacy_qa to verify on other platforms as well

@srirambv srirambv added good first issue feature/shields The overall Shields feature in Brave. OS/Windows labels Sep 20, 2018
@srirambv srirambv added this to the 1.0 milestone Sep 20, 2018
@srirambv
Copy link
Contributor Author

Dupe of #888

@srirambv srirambv modified the milestones: 1.0, Dupe / Invalid / Not actionable Sep 20, 2018
@srirambv srirambv added closed/duplicate Issue has already been reported and removed OS/Windows feature/shields The overall Shields feature in Brave. good first issue labels Sep 20, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

2 participants