Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Tor window changes browser icon #1208

Open
srirambv opened this issue Sep 20, 2018 · 2 comments
Open

Pin Tor window changes browser icon #1208

srirambv opened this issue Sep 20, 2018 · 2 comments
Labels
bug feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".

Comments

@srirambv
Copy link
Contributor

Description

Pin Tor window changes browser icon

Steps to Reproduce

  1. Open a Tor window on 0.55.5
  2. Click on pin window on taskbar
  3. Changes browser icon from Dev icon to Release build icon

Actual result:

https://youtu.be/DeHyeth1ijo

Expected result:

Should not change icon when pinned

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Reproducible on current release:

No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#725
cc: @simonhong @bbondy @darkdh
@srirambv srirambv added this to the 1.0 milestone Sep 20, 2018
@darkdh
Copy link
Member

darkdh commented Sep 20, 2018

what about guest window?

@srirambv
Copy link
Contributor Author

Same for guest window as well

@tildelowengrimm tildelowengrimm added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 23, 2018
@tildelowengrimm tildelowengrimm modified the milestones: 1.0, 1.x Backlog Oct 23, 2018
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label Oct 23, 2018
@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 28, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@MadhaviSeelam MadhaviSeelam mentioned this issue May 13, 2022
Closed
38 tasks
@pgrepds pgrepds mentioned this issue May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tildelowengrimm @bsclifton @rebron @darkdh @srirambv @riastradh-brave