Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher not obtained until rewards extension starts #12307

Closed
NejcZdovc opened this issue Oct 24, 2020 · 2 comments · Fixed by brave/brave-core#6978
Closed

Publisher not obtained until rewards extension starts #12307

NejcZdovc opened this issue Oct 24, 2020 · 2 comments · Fixed by brave/brave-core#6978
Assignees
@emerick
Labels
feature/rewards OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.18.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 24, 2020 •
edited
Loading

We should probably move api's for GL from rewards extension into brave extension (shields extension) which is running all the time. This way publisher can be always saved from GL
@NejcZdovc NejcZdovc mentioned this issue Oct 24, 2020
Closed
15 tasks
@emerick
Copy link
Contributor

emerick commented Oct 26, 2020

Just noting here that we'll also need to start the process when you click on the tip button, per @NejcZdovc.

@diracdeltas diracdeltas mentioned this issue Oct 26, 2020
Closed
This was referenced Oct 28, 2020
Merged
Merged
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Nov 11, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 24, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.18.61 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

Testing completed with #6462 (comment)

Verification passed on


Brave | 1.18.68 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Testing completed with #6462 (comment)

@LaurenWags LaurenWags mentioned this issue Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

Move Greaselion handling into Brave extension brave/brave-core
4 participants
@emerick @NejcZdovc @LaurenWags @GeetaSarvadnya