Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] GitHub favicon does not display on panel/rewards page when using dark theme #12520

Closed
LaurenWags opened this issue Nov 4, 2020 · 1 comment
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

If your install is using the "dark" theme, the standard GitHub favicon will not display on the panel or in brave://rewards.

This is similar to #9030 which noted this for the NTP top site tiles. On that issue, there's a comment noting that GH favicons are theme-aware, #9030 (comment). Logging this issue for Rewards as I didn't want to assume any work done with that issue would carry over to rewards pages.

Steps to Reproduce

  1. Use dark theme and have rewards enabled
  2. Navigate to a GH publisher (non-verified is best so you get the default favicon)
  3. Open panel

Actual result:

Looks like no favicon
Screen Shot 2020-11-04 at 2 50 04 PM

Expected result:

GH favicon to be displayed

Reproduces how often:

easily

Brave version (brave://version info)

1.17.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes, 1.16.x
  • Can you reproduce this issue with the beta channel? yes, 1.17.x
  • Can you reproduce this issue with the nightly channel? yes, 1.18.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@NejcZdovc NejcZdovc added the design A design change, especially one which needs input from the design team label Nov 4, 2020
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label Jul 20, 2022
@Miyayes
Copy link
Collaborator

Miyayes commented May 26, 2023

image

Brave 1.51.118 Chromium: 113.0.5672.126 (Official Build) (x86_64)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants