Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Brave Ads anti-targeting #14224

Closed
moritzhaller opened this issue Feb 17, 2021 · 1 comment · Fixed by brave/brave-core#8167
Closed

Implement Brave Ads anti-targeting #14224

moritzhaller opened this issue Feb 17, 2021 · 1 comment · Fixed by brave/brave-core#8167

Comments

@moritzhaller
Copy link

moritzhaller commented Feb 17, 2021

The new "anti-targeting" model should enable advertisers to target users that are not their customers yet. As proxy for "non-customers" we consider as an audience the set of users that haven’t visited any of the advertiser's websites at the time of serving the ad.

High-level flow:

  1. When a new segment is published the client calls out to the browsing history to check if any of the advertiser's websites has been visited in the past
  2. On every subsequent page load the eTLD+1 of the visited domain is checked if it is one of the advertiser's websites
  3. If non the checks in 1. and 2. have failed the user will be eligible to receive an ad from the segment
@moritzhaller moritzhaller added feature/ads enhancement needs-more-info The report requires more detail before we can decide what to do with this issue. labels Feb 17, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Desktop and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Mar 8, 2021
@tmancey tmancey changed the title Anti-Targeting for Brave Ads Implement Brave ads anti-targeting Mar 12, 2021
@tmancey tmancey changed the title Implement Brave ads anti-targeting Implement Brave Ads anti-targeting Mar 12, 2021
@moritzhaller moritzhaller added this to the 1.24.x - Nightly milestone Apr 4, 2021
@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 15, 2021
@btlechowski
Copy link

Verification passed on

Brave 1.24.70 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from https://github.com/brave/internal/issues/767. Used --use-dev-goupdater-url flag

Notification ad - eTLD+1 anti-targeting site - show ad
Verified mkdhnfmjhklfnamlheoliekgeohamoig is loaded

[6889:6889:0423/170515.712382:VERBOSE1:anti_targeting_resource.cc(42)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[6889:6889:0423/170515.712877:VERBOSE1:anti_targeting_resource.cc(114)] Parsed anti targeting resource version 1
[6889:6889:0423/170515.712920:VERBOSE1:anti_targeting_resource.cc(52)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig

Verified the ad was shown:

[6889:6889:0423/170729.659783:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: cea2a459-7e54-4639-be59-50d4b790f05f
  creativeInstanceId: 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad2 - same set
  body: Ad2 - same set
  targetUrl: https://youtube.com

Notification ad - eTLD+1 anti-targeting site - prevent ad
FAIL- the ad was shown. Logged #15467

Notification ad - full URL anti-targeting site - show ad
Verified mkdhnfmjhklfnamlheoliekgeohamoig is loaded

[14351:14351:0423/185614.014682:VERBOSE1:anti_targeting_resource.cc(42)] Successfully loaded resource mkdhnfmjhklfnamlheoliekgeohamoig
[14351:14351:0423/185614.014725:VERBOSE1:anti_targeting_resource.cc(114)] Parsed anti targeting resource version 1
[14351:14351:0423/185614.014790:VERBOSE1:anti_targeting_resource.cc(52)] Successfully initialized resource mkdhnfmjhklfnamlheoliekgeohamoig

Verified the ad was shown:

[14351:14351:0423/185717.933496:VERBOSE1:ad_notification_serving.cc(105)] Ad notification delivered:
  uuid: cc97ac13-6365-4f01-a8ec-18a1cdda869d
  creativeInstanceId: 5b4cb3f4-5285-4597-87c5-3082fe37938a
  creativeSetId: c7e7a381-4c74-4dd9-9b6d-4edf9330454b
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad1 - same set
  body: Ad1 - same set
  targetUrl: https://youtube.com

Notification ad - full URL anti-targeting site - prevent ad
Verified the ad was not shown:

[13141:13141:0423/180156.916634:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as user has previously visited an anti-targeting site

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants