Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a notification when user has exceeded wallet linking limit #15028

Closed
zenparsing opened this issue Mar 30, 2021 · 3 comments · Fixed by brave/brave-core#8391
Closed

Show a notification when user has exceeded wallet linking limit #15028

zenparsing opened this issue Mar 30, 2021 · 3 comments · Fixed by brave/brave-core#8391

Comments

@zenparsing
Copy link

Description

When the user connects an Uphold external wallet to Rewards, but they are unable to link the wallet because they have exceeded the linking limit, we should display a notification in the rewards panel.

@kjozwiak
Copy link
Member

kjozwiak commented Apr 20, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2009 (Build 19042.928)

Limit Reached Cases (Production)

  • verified the STR/cases outlined via Show a rewards notification when Uphold wallet linking limit is reached brave-core#8391 (comment)
  • ensured that connecting to a wallet that exceeds the linking limit correctly displays the notification via the rewards panel
  • ensured that clicking on X dismisses the notification without any issues
  • ensured that clicking on Learn More opens https://support.brave.com/hc/en-us/articles/360056508071 in a new tab
  • ensured that once the notification is dismissed via X or Learn More, it doesn't re-appear after restarting the browser
  • ensured that disconnected/re-connecting the wallet displays the linking limit notification without any issues
  • ensured that device_limit_reached is being recorded within the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached is being recorded in publisher_info_db via the event_log table
Example Example Example
Screenshot 2021-04-19 231442 Screenshot 2021-04-19 231722 Screenshot 2021-04-19 232220

Limit NOT Reached Cases (Staging)

  • ensured that the notification isn't displayed when logging into an account that hasn't reached the limitations of 4 devices
  • ensured that device_limit_reached isn't being added/displayed in the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached isn't being recorded in publisher_info_db via the event_log table
  • ensured that you can drain the BAT from Brave to Uphold without any issues
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"17ee8cff-aa4a-4539-988d-e97543034c87"}

Screenshot 2021-04-20 000558


Verification PASSED on Ubuntu 20.04 x64 using the following build:

Brave | 1.24.77 Chromium: 90.0.4430.85 (Official Build) dev (64-bit)
--- | ---
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | Linux

Limit Reached Cases (Production)

  • verified the STR/cases outlined via Show a rewards notification when Uphold wallet linking limit is reached brave-core#8391 (comment)
  • ensured that connecting to a wallet that exceeds the linking limit correctly displays the notification via the rewards panel
  • ensured that clicking on X dismisses the notification without any issues
  • ensured that clicking on Learn More opens https://support.brave.com/hc/en-us/articles/360056508071 in a new tab
  • ensured that once the notification is dismissed via X or Learn More, it doesn't re-appear after restarting
    the browser
  • ensured that disconnected/re-connecting the wallet displays the linking limit notification without any issues
  • ensured that device_limit_reached is being recorded within the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached is being recorded in publisher_info_db via the event_log table
Example Example Example
image Screenshot 2021-04-29 152504 Screenshot 2021-04-29 212916

Limit NOT Reached Cases (Staging)

  • ensured that the notification isn't displayed when logging into an account that hasn't reached the limitations of 4 devices
  • ensured that device_limit_reached isn't being added/displayed in the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached isn't being recorded in publisher_info_db via the event_log table
  • ensured that you can drain the BAT from Brave to Uphold without any issues
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"48d2e8d8-978f-4c5e-ae1b-b945afa88814"}

image


Verification PASSED on macOS 11.2.3 4 x64 using the following build:

Brave | 1.24.77 Chromium: 90.0.4430.85 (Official Build) dev (x86_64)
--- | ---
Revision | 5bc145d831c180d9ff94f29a0d7a2e1cbd30ef36-refs/branch-heads/4430@{#1311}
OS | macOS Version 11.2.3 (Build 20D91

Limit Reached Cases (Production)

  • verified the STR/cases outlined via Show a rewards notification when Uphold wallet linking limit is reached brave-core#8391 (comment)
  • ensured that connecting to a wallet that exceeds the linking limit correctly displays the notification via the rewards panel
  • ensured that clicking on X dismisses the notification without any issues
  • ensured that clicking on Learn More opens https://support.brave.com/hc/en-us/articles/360056508071 in a new tab
  • ensured that once the notification is dismissed via X or Learn More, it doesn't re-appear after restarting
    the browser
  • ensured that disconnected/re-connecting the wallet displays the linking limit notification without any issues
  • ensured that device_limit_reached is being recorded within the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached is being recorded in publisher_info_db via the event_log table
Example Example Example
Screen Shot 2021-04-29 at 10 07 15 PM Screen Shot 2021-04-29 at 10 07 15 PM Screen Shot 2021-04-29 at 10 10 25 PM

Limit NOT Reached Cases (Staging)

  • ensured that the notification isn't displayed when logging into an account that hasn't reached the limitations of 4 devices
  • ensured that device_limit_reached isn't being added/displayed in the Event logs tab via brave://rewards-internals
  • ensured that device_limit_reached isn't being recorded in publisher_info_db via the event_log table
  • ensured that you can drain the BAT from Brave to Uphold without any issues
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"712df147-1459-43c6-8a26-e08c81ac5af3"}

Screen Shot 2021-04-29 at 10 21 17 PM

@kjozwiak
Copy link
Member

@Miyayes @zenparsing should we display the warning every single time a user disconnected/re-connects the same wallet? I don't think it makes sense to keep displaying it. Maybe we can display it the first ~3-4 times and stop after that? Just a thought as it might annoy users but at the same time, I guess it makes sure that a user remembers that they've hit the limit.

@Miyayes thoughts?

Quick Example:

Screenshot 2021-04-19 233752

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 21, 2021

I would like to tell the user every single time they attempt to verify/re-verify over the linking limit that they've exceeded the linking limit. So, we can keep the current behavior. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment