Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor typos in remove-device dialog prompt text #15251

Closed
stephendonner opened this issue Apr 12, 2021 · 2 comments · Fixed by brave/brave-core#8558
Closed

Minor typos in remove-device dialog prompt text #15251

stephendonner opened this issue Apr 12, 2021 · 2 comments · Fixed by brave/brave-core#8558

Comments

@stephendonner
Copy link

Description

Minor typos in remove-device dialog prompt text

Steps to Reproduce

  1. on (desktop) deviceA, load brave://settings/braveSync/setup
  2. click on the Start a new Sync Chain button
  3. click OK
  4. on another machine, deviceB, join the sync chain either via QR code (mobile) or by manually entering and pairing with the pass-phrase (desktop)
  5. back on deviceA, load brave://settings/braveSync/setup and click on the (x) to remove deviceB
  6. look at the resulting dialog prompt

Actual result:

The prompt text reads Are you sure you want to delete selected device from sync chain?

Screen Shot 2021-04-09 at 11 33 02 AM

Expected result:

The prompt should read Are you sure you want to remove the selected device from the sync chain?

Suggestions:

  1. Add "the" before "selected device"
  2. Add "the" before "sync chain?"
  3. Change delete to remove, to match the Remove column heading

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.25.10 Chromium: 90.0.4430.61 (Official Build) nightly (x86_64)
Revision dced74d4124b26b14126b611853d33512b60c7b6-refs/branch-heads/4430@{#1115}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 16, 2021
@rahulsnkr
Copy link

Can I take this up?

@stephendonner
Copy link
Author

Verified FIXED using nightly build

Brave 1.25.46 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3 (Build 20E232)

Screen Shot 2021-04-27 at 3 39 08 PM

Confirmed the text now says Are you sure you want to remove the selected device from the sync chain?

Thanks again for the fix, @rahulsnkr! 👍 (And for reviewing and landing, @AlexeyBarabash!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants