rewards panel and tip banner messaging mismatch in certain cases

[LaurenWags]

Description

In the anon wallet state (only Rewards BAT present, no KYC wallet connected), in certain cases the rewards panel and tip banners have conflicting/mismatched messaging.

Steps to Reproduce

Scenario 1 - US region

1. Clean profile, staging environment
2. Enable Rewards, claim UGP grant
3. Navigate to nike.com (unverified publisher), ddg (connected publisher), and laurenwags.github.io (Uphold KYC publisher)
4. Open panel and tip banner for each
5. In all of these cases the panel and banner messaging match (tips not allowed to Nike, are allowed to the other two)
6. Now visit batcommunity.org (bF KYC publisher)
7. Open panel and tip banner
8. Panel indicates that this publisher cannot be tipped, but tip banner doesn't display this messaging
9. In this case, the panel is wrong and should not be displaying any messaging. The tip banner is correct. In fact, if you tip this publisher the tip gets deducted from balance and is reflected in UI.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Scenario 2 - JP region

1. Clean profile, staging environment
2. Enable Rewards, claim UGP grant
3. Navigate to nike.com (unverified publisher), ddg (connected publisher), and batcommunity.org (bF KYC publisher)
4. Open panel and tip banner for each
5. In all of these cases the panel and banner messaging match (tips not allowed to Nike, are allowed to the other two)
6. Now visit laurenwags.github.io (Uphold KYC publisher)
7. Open panel and tip banner
8. Panel indicates that this publisher cannot be tipped, but tip banner doesn't display this messaging
9. In this case, the panel is wrong and should not be displaying any messaging. The tip banner is correct. In fact, if you tip this publisher the tip gets deducted from balance and is reflected in UI.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Actual result:

Panel and tip banner messaging mismatch (panel is incorrectly showing the messaging, tip banner is correctly not showing messaging)

Expected result:

No mismatch, both panel and tip banner should be consistent with messaging

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.24.70 Chromium: 90.0.4430.72 (Official Build) beta (x86_64)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	macOS Version 10.15.7 (Build 19H524)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.23.x n/a
• Can you reproduce this issue with the beta channel? 1.24.x yes
• Can you reproduce this issue with the nightly channel? 1.25.x yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing @emerick

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 1.24.x

[LaurenWags]

Verified passed with

Brave	1.24.83 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified STR from description and additional scenarios listed below.

Scenarios

Scenario 1 - US region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel

Scenario 2 - Japan region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel

Scenario 3 - US region w/ Uphold wallet

Confirmed correct messaging in Uphold KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to Uphold KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel

Scenario 4 - Japan region w/ bF wallet

Confirmed correct messaging in bF KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to bitFlyer KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel

---

Verification passed on

Brave	1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Windows 10 OS Version 1809 (Build 17763.1637)

Verified the scenarios mentioned above

Scenarios

Scenario 1 - US region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel	Monthly statement

Scenario 2 - Japan region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel

Scenario 3 - US region w/ Uphold wallet

Confirmed correct messaging in Uphold KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to Uphold KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel

Scenario 4 - Japan region w/ bF wallet

Confirmed correct messaging in bF KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to bitFlyer KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel

---

Verification passed on

Brave	1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Ubuntu 18.04 LTS

Verified STR from description and additional scenarios listed below.

Scenarios

Scenario 1 - US region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel

Scenario 2 - Japan region w/ anon wallet

Confirmed correct messaging in anon wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed tips to connected, Uphold KYC, and bF KYC were allowed, tip to unverified were sent to Pending

Pending List	Tips	Wallet panel

Scenario 3 - US region w/ Uphold wallet

Confirmed correct messaging in Uphold KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to Uphold KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel

Scenario 4 - Japan region w/ bF wallet

Confirmed correct messaging in bF KYC wallet case for the 4 publisher types below.

Unverified Publisher	Connected Publisher	Uphold Publisher	bF Publisher

Confirmed only tips to bitFlyer KYC publisher were allowed, tips to others were sent to Pending

Pending List	Tips	Wallet panel