brave://memories link in brave://aboutdoesn't work

[stephendonner]

Description

brave://memories link in brave://aboutdoesn't work

Steps to Reproduce

1. load brave://about/
2. enable the feature flag via brave://flags
3. click on chrome://memories, which redirects internally to brave://memories/

Actual result:

Broken internal link

example	example	example

Expected result:

Working link, or for it to be removed

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.24.81 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 11.3 (Build 20E232)

[bsclifton]

@stephendonner can you try enabling brave://flags/#memories and then seeing if it works?

More info here:
https://www.ghacks.net/2021/04/24/google-is-working-on-a-new-browsing-history-interface-called-memories-in-chrome/

[stephendonner]

@bsclifton shortly after @rebron told me it requires a flag, in Slack, I amended the steps and screenshots here to reflect that I re-tested with that feature flag enabled. Confirming that it still isn't displaying anything for me with

Brave	1.26.6 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 11.3.1 (Build 20E241)

[stephendonner]

Verified PASSED using

Brave	1.30.56 Chromium: 93.0.4577.58 (Official Build) beta (x86_64)
Revision	c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS	macOS Version 11.5.2 (Build 20G95)

Steps:

1. new profile
2. launched Brave
3. opened brave://about
4. looked for brave://memories

Confirmed that brave://memories is now removed from brave://about; however it's still present in brave://flags

@goodov should we also remove the two memories items in brave://flags, in a separate issue?

example	example	example

[goodov]

@goodov should we also remove the two memories items in brave://flags, in a separate issue?

why not, let's clean up this.