Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reading List in Brave #15583

Closed
phoogm opened this issue Apr 30, 2021 · 4 comments
Closed

Add Reading List in Brave #15583

phoogm opened this issue Apr 30, 2021 · 4 comments
Assignees
Labels
closed/duplicate Issue has already been reported feature/settings feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop

Comments

@phoogm
Copy link

phoogm commented Apr 30, 2021

Description

As a user I would like to see the option in the Settings / Appearance section to enable or disable the Reading List option (brave://flags - Reading list) so I can save web page articles (offline) without the need to save it as a bookmark and track read versus unread status.

Steps to Reproduce

  1. Go to brave://flags
  2. Enable Reading List
  3. Observe the Reading List button to appear in the bookmarks bar behind a separator
  4. Currently the description mentions that clicking the bookmarks icon would work but as far as i can see only right-clicking on the tab would allow to add a page to the Reading List.

Actual result:

Brave Reading List

Reading list tab

Expected result:

User can enable or disable the Reading List option in the Settings / Appearance section
Reading list follows the Brave styling in stead of the current Chromium styling.
Description accurately states that the user should right-click on a tab to add the current page to the reading list.

Reading List Proposal

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.23.75 Chromium: 90.0.4430.93 (Official Build) (arm64)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS macOS Version 11.3 (Build 20E232)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Potentially a feature to enable or add to the mobile versions as well.

Thanks much for looking into, best regards.

@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature-request feature/settings labels Apr 30, 2021
@rebron
Copy link
Collaborator

rebron commented May 3, 2021

cc: @karenkliu @bradleyrichter Thoughts?

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 3, 2021
@kpmridge
Copy link

I've tried this over and over - enabling, disabling, restarting Brave. No matter what, I get no reading list. I have no option to add to a reading list by right clicking on a tab, or in the bookmarks. Reading List does not appear in settings/Appearance. It seems so simple. What could I be doing wrong? Does it actually work?

Reading list was my favorite Chrome feature, so I can synch my reading list across my Mac, iPhone, and iPad. I want to use Brave, but I will have to go back to Chrome if I can't get this working.

@wolfemb
Copy link

wolfemb commented Oct 17, 2021

I'm seeing similar behavior with my browser, but oddly, my main account does not show reading list, while my other account on the PC does (possibly the other does not have any other bookmarks in it though). I was able to work around the issue doing the following.

  • Open flags. Disable reading list, and relaunch
  • Open flags. Enable reading list AND side panel. Relaunch
  • The side panel icon appears at top. Opening it enabled me to view my reading list. Also, I now have the option to right-click tabs and add them to the reading list.

Hopefully this is fixed soon. I like this feature.

@bsclifton
Copy link
Member

bsclifton commented Sep 14, 2022

Closing as this is now implemented 😄 Kudos to @petemill for integrating this with brave/brave-core#13769

Duplicate of #17959

@bsclifton bsclifton removed the priority/P4 Planned work. We expect to get to it "soon". label Sep 14, 2022
@bsclifton bsclifton modified the milestone: 1.44.x - Beta Sep 14, 2022
@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/settings feature-request needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop
Projects
None yet
Development

No branches or pull requests

6 participants