Browser should not lose focus when a custom ad notification is displayed

[tmancey]

Description

Browser should not lose focus when a custom ad notification is displayed

Steps to Reproduce

1. Launch browser
2. Click in the address bar
3. Wait for ad notification to be displayed
4. Type on the keyboard

Actual result:

The user is unable to type in the address bar as the browser window has lost focus

Expected result:

User should be able to type in the address bar

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[bsclifton]

Ran into this yesterday; just seeing the issue now 😄 Nice fix, @tmancey!

cc: @rebron @stephendonner - this is the issue I had mentioned in triage 😄

[stephendonner]

Verified FIXED using

Brave	1.26.11 Chromium: 90.0.4430.93 (Official Build) nightly (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 11.3.1 (Build 20E241)

Steps:

1. launched browser
2. enabled Rewards; skipped onboarding tour
3. opened a few new-tab pages
4. typed abc in the URL bar
5. waited for ad notification to be displayed
6. resume typing on the keyboard

Confirmed I was able to keep typing while the ad-notification popup was still displayed, without needing to re-focus the URL bar using command + L

---

Verification passed on

Brave	1.26.50 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Verified I was able to keep typing while the ad-notification popup was still displayed, without needing to re-focus the URL bar

---

Verification passed on

<!--StartFragment-->
Brave | 1.26.50 Chromium: 91.0.4472.77&nbsp;(Official Build)&nbsp;beta&nbsp;(64-bit)
-- | --
Revision | 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS | Windows&nbsp;10 OS Version 2004 (Build 19041.985)

<!--EndFragment-->

Verified I was able to keep typing while the ad-notification popup was still displayed, without needing to re-focus the URL bar

[stephendonner]

Marking as QA/Test-All-Platforms as -- especially Linux, with its many window managers -- can have different focus issues/behaviors.