Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 91.0.4472.19 to Chromium 91.0.4472.38. #15641

Closed
mkarolin opened this issue May 5, 2021 · 3 comments · Fixed by brave/brave-core#8729 or #15658
Closed

Upgrade from Chromium 91.0.4472.19 to Chromium 91.0.4472.38. #15641

mkarolin opened this issue May 5, 2021 · 3 comments · Fixed by brave/brave-core#8729 or #15658
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude
Milestone
1.25.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented May 5, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/91.0.4472.19..91.0.4472.38?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels May 5, 2021
@mkarolin mkarolin self-assigned this May 5, 2021
This was referenced May 6, 2021
Merged
Merged
Merged
@mkarolin mkarolin added this to the 1.26.x - Nightly milestone May 7, 2021
@mkarolin mkarolin mentioned this issue May 7, 2021
Closed
@stephendonner
Copy link

Verified PASSED using

Brave 1.26.18 Chromium: 91.0.4472.38 (Official Build) nightly (64-bit)
Revision 8155e7afab5d695cf0e028f4d77203287523cda9-refs/branch-heads/4472_35@{#6}
OS Windows 10 OS Version 2009 (Build 21376.1)

Checked both brave://version as well as brave://settings/help for branding and correct CR + Brave versions.

brave://version brave://settings/help
brave-cr-version brave-cr-help-page

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels May 19, 2021
@kjozwiak
Copy link
Member

Labeling as QA/No and adding release-notes/exclude in favour of #15800.

@LaurenWags
Copy link
Member

Removing release-notes/include and changing to release-notes/exclude as this is superseded by #16054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass-Win64 QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.25.x - Release
4 participants
@stephendonner @kjozwiak @LaurenWags @mkarolin