Top Sites - Favorites - favicon icons disappear in dark mode

[phoogm]

Description

Using Brave 24.82 Desktop with Top Sites enabled the GitHub favicon disappears when MacOS switches from light to dark mode. When looking at the other favicon images it seems the switch impacts transparant sections of the favicon images as well in stead of only affecting the tile border around the favicon image.

Steps to Reproduce

1. Enable Top Sites
2. Add a GitHub site
3. Switch from light to dark mode and observe that the GitHub favicon has disappeared

Actual result:

Expected result:

Dark mode should keep the favicon intact, e.g. the GitHub icon is white in black and the MS Office icon red on a white background, the BBC icon is dark tiles on white but looses the details and is effectively reduced to 3 white characters.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	1.24.82 Chromium: 90.0.4430.93 (Official Build) (arm64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 11.3.1 (Build 20E241)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? N/A
• Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Thanks for looking into, best regards.

[rebron]

@phoogm If you click through on the dark top sites icon and refresh the page or open a new tab, the right image should show up.