Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Brave shield! #15710

Open
Wileyfox-F1 opened this issue May 10, 2021 · 1 comment
Open

Bug in Brave shield! #15710

Wileyfox-F1 opened this issue May 10, 2021 · 1 comment
Assignees
Labels
feature/shields The overall Shields feature in Brave. needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop

Comments

@Wileyfox-F1
Copy link

Description

Brave shield itself reverts back to standard settings after I configured it to behave in extreme manner. This problem occurs frequently after the last couple of updates (Fine with previous builds). I noticed this change in behavior when I found an embedded ad in the Yandex images website (Which was not there with extreme behavior).

Steps to Reproduce

  1. Open the browser for a new session.
  2. Check the shield settings if it is in standard settings or not. Toggle to extreme
    behavior if it is in standard by default due to the bug.

Screenshot 2021-05-10 115154

  1. Inspect the shield settings after a while.

Actual result:

As mentioned in the description it reverts back to standard settings

Screenshot 2021-05-10 115127

Expected result:

Screenshot 2021-05-10 120244

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave: 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision: 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS: Windows 10 OS Version 2009 (Build 19042.906)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Ans: Yes
  • Can you reproduce this issue with the beta channel?
    Ans: Not tried
  • Can you reproduce this issue with the nightly channel?
    Ans: Not tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    Ans: Invalid question
  • Does the issue resolve itself when disabling Brave Rewards?
    Ans: Not tried
  • Is the issue reproducible on the latest version of Chrome?
    Ans: Yes

Miscellaneous Information:

None

@rebron
Copy link
Collaborator

rebron commented Aug 19, 2021

@Wileyfox-F1 When you get a chance, an you update to our latest 1.28.106. I just tried your steps to reproduce using your github example and couldn't see the issue.

If you have Clear browser data (on exit) for Site and Shields Settings marked as checked, it will reset shields settings also.

@rebron rebron added needs-more-info The report requires more detail before we can decide what to do with this issue. feature/shields The overall Shields feature in Brave. labels Aug 19, 2021
@rebron rebron self-assigned this Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop
Projects
None yet
Development

No branches or pull requests

2 participants