System-notification ads don't auto-dismiss after click/landing, nor do they time-out

[stephendonner]

Description

System-notification ads don't auto-dismiss after click/landing, nor do they time-out

Steps to Reproduce

1. new profile
2. launch Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
3. click to enable Rewards
4. open 4+ tabs
5. wait
6. do some activity (type, move mouse)
7. confirm the system-notification ad shows up
8. click on the ad
9. wait...

Actual result:

The system-ad notification never dismisses upon click, and doesn't time-out either (as others do in 120 seconds?)

clicked ad	waited

It's also possible, in this state, to have stacked ad notifications.

stack	stack unfurled

Expected result:

Native/system-notification ad should dismiss upon successful click/land, per @tmancey in Slack thread: https://bravesoftware.slack.com/archives/CJR5902AW/p1623281231116200

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.27.57 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision	af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS	macOS Version 11.4 (Build 20F71)

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @btlechowski

[stephendonner]

Also broken in

Brave	1.26.59 Chromium: 91.0.4472.101 (Official Build) beta (x86_64)
Revision	af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS	macOS Version 11.4 (Build 20F71)

/cc @tmancey

[btlechowski]

Not reproducible on Ubuntu

Brave	1.26.59 Chromium: 91.0.4472.101 (Official Build) beta (64-bit)
Revision	af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS	Ubuntu 18.04 LTS

Click:

Dismiss:

[LaurenWags]

Reproduced with

Brave | 1.26.58 Chromium: 91.0.4472.88 (Official Build) dev (x86_64)
-- | --
Revision | 109e9cd038b94a631aea7d40ee3d56c1278f2597-refs/branch-heads/4472@{#1385}
OS | macOS Version 10.15.7 (Build 19H1030)

Additionally, this is how multiple clicked ads (which did not dismiss) display on screen:

[stephendonner]

Verified PASSED using the inline steps here on build

Brave	1.26.65 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision	4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS	macOS Version 11.4 (Build 20F71)

Steps:

1. new profile
2. launch Brave using --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
3. click to enable Rewards
4. open 4+ tabs
5. wait
6. do some activity (type, move mouse)
7. confirm the system-notification ad shows up
8. click on the ad

Confirmed ad was automatically dismissed, upon click
Confirmed ad landed:

[4350:259:0621/161817.881158:VERBOSE6:ad_transfer.cc(138)] Successfully logged transferred ad event
[4562:259:0621/163938.103544:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 29c55d0a-a926-4f3e-af37-e0dc4ea8bb33, creative instance id faec6d5b-9e30-45a5-8420-3435abe1695a and landed

Confirmed click registered:

[4350:259:0621/161807.452503:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id c935f8a6-5ba2-45a2-8b8e-5acc504e8cdf, creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d and click

Confirmed click logged:

[4350:259:0621/161807.012168:VERBOSE1:ad_notification_event_clicked.cc(38)] Successfully logged ad notification clicked event

[4350:259:0621/161818.173295:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 05a6aecb-e823-41b8-8eeb-d3c101a23aaf, creative instance id 04064736-ea43-463a-bd6e-6c2be4408b4d and landed

Confirmed ad showed up on brave://rewards
Confirmed BAT shown on new-tab page widget

brave://rewards	Ads History	NTP widget

Confirmed ads will time out after 120 seconds, without an explicit click

---

Verified passed with

Brave	1.26.65 Chromium: 91.0.4472.114 (Official Build) (64-bit)
Revision	4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS	Linux

Confirmed ad was automatically dismissed, upon click
Confirmed ad landed:

[4302:4302:0621/074258.432785:VERBOSE6:ad_transfer.cc(138)] Successfully logged transferred ad event

[4302:4302:0621/074258.867577:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 6fd40d35-fb30-452a-95d6-c9147a9a20ff, creative instance id d23b41d2-74b5-42b3-8169-5017984731ee and landed

Confirmed click registered:

[4302:4302:0621/074245.186406:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 50d4d1e4-27a8-40ba-b6bb-b95700f8e6b5, creative instance id d23b41d2-74b5-42b3-8169-5017984731ee and click

Confirmed click logged:

[4302:4302:0621/074244.928805:VERBOSE1:ad_notification_event_clicked.cc(38)] Successfully logged ad notification clicked event

Confirmed ad showed up on brave://rewards/
Confirmed BAT shown on new-tab page widget

brave://rewards	Ad History	NTP widget

Confirmed ads will time out after 120 seconds, without an explicit click

[5336:5336:0621/075958.952028:VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid c81a4b0e-4099-4f46-a086-d5f7acbde118 in 120 seconds

[5336:5336:0621/080158.953787:VERBOSE3:ad_notification_event_timed_out.cc(22)] Timed out ad notification with uuid c81a4b0e-4099-4f46-a086-d5f7acbde118 and creative instance id 4cda3ae7-1f70-4bca-b361-ca01d6a8f1ed

---

Verified PASSED using

Brave	1.26.65 Chromium: 91.0.4472.114 (Official Build) (64-bit)
Revision	4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS	Windows 10 OS Version 2009 (Build 21390.2025)

Confirmed ad was dismissed, upon click

Confirmed ad landed:

[10988:12512:0621/133117.316:VERBOSE1:confirmations.cc(89)] Confirming landed ad for creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88

Confirmed click registered:

[10988:12512:0621/133117.542:VERBOSE1:confirmations.cc(248)] Successfully redeemed unblinded token with confirmation id 4d2e5bdf-9d5d-4fd4-ae2d-407d05524b1a, creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88 and landed

Confirmed click logged:

[10988:12512:0621/133106.504:VERBOSE1:ad_notification_event_clicked.cc(38)] Successfully logged ad notification clicked event
[10988:12512:0621/133117.347:VERBOSE6:ad_transfer.cc(138)] Successfully logged transferred ad event

Confirmed ads will time out after 120 seconds, without an explicit click:

[2508:19680:0621/134103.677:VERBOSE1:ads_service_impl.cc(1819)] Timeout ad notification with uuid 2d7accd8-8adf-4864-bbc7-ff6a1731386d in 120 seconds

Confirmed ad showed up on brave;//rewards
Confirmed BAT shown on new-tab page widget

brave://rewards	ads history	ntp widget