Move Tor settings to Privacy and security section (brave://settings/privacy)

[rebron]

Description

The extensions section of brave://settings is overused and cluttered.

Move Tor settings into Privacy and security section.
brave://settings/privacy

New and Expected Design

Existing Design

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? n/a
• Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Figma: https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=2187%3A60437

[aguscruiz]

Updated design here:
https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=2187%3A60437

I do think this looks pretty bare bones, so I wonder if we couldn't group these settings with another section

[rebron]

Fixed with brave/brave-core#13290

[stephendonner]

Verification PASSED using

Brave	1.44.92 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision	872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS	Windows 10 Version 21H2 (Build 19044.2006)

Settings/UI

Case 1: New Tor windows sub-section of Privacy & Security - PASSED

Confirmed a new Tor windows section exists in brave://settings/privacy, with the following preferences and default values:

• Private window with Tor - ON
• Automatically redirect .onion sites - OFF
• Use Bridges - OFF

Case 2: Toggle Private window with Tor to OFF - PASSED

Confirmed when Private window with Tor is disabled, Automatically redirect .onion sites and Use Bridges are disabled

Case 3: Enabling Use Bridges should expand to additional settings - PASSED

Confirmed toggling Use Bridges to Enabled expands to the following three radio-button options:

• Select a built-in bridge with obfs4 selected
• Request a bridge from torproject.org w/read-only textfield and Request a New Bridge... button
• Provide a bridge with input textfield
• also confirmed toggling it to Disabled collapses it to its original state

Case 4: Apply changes button should be dynamic - PASSED

Confirmed the following:

• the Apply changes button appears after changing input values and/or radio-button selections (with input)
• after clicking Apply changes, the button disappears until another change is made
• the Apply changes button correctly disappears if a value was changed (to trigger the button) but not /applied/, and then reverted to its original value

Select a built-in-bridge	Request a bridge from torproject.org	Provide a bridge

Bridges (basic)

Case 1: Built-in bridges listing - PASSED

Confirmed built-in bridges are the following, in order:

• obfs4
• Snowflake
• meek-azure

Case 2: Built-in bridges functionality - PASSED

Confirmed the steps below with each of the following built-in bridges:

• obfs4
• Snowflake
• meek-azure

1. selected a bridge
2. clicked on Apply changes
3. clicked on "hamburger menu" -> New private window with Tor
4. confirmed I could load check.torproject.org
5. double-confirmed by clicking on New Tor connection for this site, and ensuring it reloads

obfs4	Snowflake	meek-azure

Case 3: Request a bridge from torproject.org - PASSED

Confirmed the following:

• empty, read-only textfield
• placeholder text on selection reads Click on "Request a New Bridge..." to get bridges
• clicking on the Request a bridge from torproject.org radio button enables the Request a New Bridge... button
• clicking the Request a New Bridge button displays a Request Bridge CAPTCHA dialog

Request a bridge from... radio button	Request a New Bridge... button

Case 3.5 Request Bridge CAPTCHA dialog - PASSED

Confirmed the following:

• X dismisses the dialog
• Cancel dismisses the dialog
• clicking the Renew button refreshes the CAPTCHA
• invalid input refreshes the CAPTCHA
• CAPTCHA solves are case-insensitive
• valid CAPTCHA submission dismisses the dialog and populates the read-only textarea with valid obfs4 bridges (obfs4 xxx.xxx.xxx:xxxx... lines)

Renew button	invalid input	valid obfs4 bridges

Logged:

• Submit button should be disabled until input #25492

Case 4: Provide a bridge - PASSED

Confirmed the following:

• empty input textarea
• placeholder text on selection reads Type address:port (one per line)
• used previous config from Request a Bridge... test
• also used configs generated from https://bridges.torproject.org/options/

focused/selected	check.torproject.org

Bridges (Detailed)

Case 1: Brave Tor Client Updater component - PASSED

• opened brave://components
• launched New private window with Tor
• confirmed Brave Tor Client Updater appears
• confirmed new 1.0.54 version (previous 1.0.28)

Case 2: Brave Pluggable Transports component - PASSED

• opened brave://settings/privacy
• clicked to toggle Use Bridges to Enabled
• clicked Apply changes
• opened brave://components
• confirmed new Brave Pluggable Transports (Windows) appears
• noted version 1.0.3

Case 3: Specific transport-binary processes - PASSED

obfs4

• continued from the above testcase
• in brave://settings/privacy, chose obfs4 (and then again with meek-azure chosen)
• clicked Apply changes
• opened a New private window with Tor
• loaded check.torproject.org
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-obfs4-brave

Snowflake

• in brave://settings/privacy, chose Snowflake
• clicked Apply changes
• opened a New private window with Tor
• loaded check.torproject.org
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-snowflake-brave

meek-azure

• in brave://settings/privacy, chose meek-azure
• clicked Apply changes
• opened a New private window with Tor
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-obfs4-brave

Case 4: Disabling bridges should stop processes and remove components from profile - PASSED

• ran through the above cases for each bridge type again, as setup
• toggled Use Bridges to Disabled
• clicked Apply changes
• examined: Task Manager and {user dir} for

Confirmed:

• no bridge-specific processes still running
• bridge-transport component directory dnkcahhmfcanmkjhnjejoomdihffoefm is deleted

Running bridges

obfs4	Snowflake	meek-azure

Disabled bridges

obfs4	Snowflake	meek-azure

Case 5: Changing bridge settings should renew IP address - PASSED

• toggled Use Bridges to Enabled on brave://settings/privacy
• clicked Apply changes
• clicked on "hamburger menu" -> New private window with Tor
• loaded yandex.com/internet
• noted the IP address - 185.14.97.176
• selected a new bridge type on brave://settings/privacy
• clicked Apply changes
• reload the yandex.com/internet tab
• noted the IP address - 185.220.101.180

Confirmed I was assigned a new IP address 185.220.101.180, replacing 185.14.97.176 after changing bridge types from obfs4 to Snowflake

obfs4 bridge	obfs4 IP	Snowflake bridge	Snowflake IP

Case 6: Bad bridge config - PASSED

• in brave://settings/privacy, pasted obfs4 99.124.226.90:9998 8BFDDB7D7D2D4BDD4169170C818B175C6B60F799 cert=fmp+hf7s1QH6Crg+FW39P5KTxy57NCfXs+t1vBrNuYrHGebGtbRrdkKfk+pcgZhBdbrVcw iat-mode=0 (from the provided testplan) into the Provide a bridge textarea
• clicked Apply changes
• clicked "hamburger menu" -> New private window with Tor
• loaded brave.com
• waited

Confirmed I got the Tor connection failed error message

• clicked on the Brave Settings and bridges links, which go to brave://settings/privacy
• clicked on the contact support link and confirmed it loaded https://support.brave.com/hc/en-us in a new tab

brave://settings/privacy	Tor connection failed	support.brave.com

[stephendonner]

Verification PASSED using

Brave	1.44.99 Chromium: 106.0.5249.55 (Official Build) (x86_64)
Revision	4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS	macOS Version 11.7 (Build 20G817)

Settings UI

Case 1: New Tor windows sub-section of Privacy & Security - PASSED

* Private window with Tor - `On` * Automatically redirect .onion sites` `Off` * Use Bridges `Off`

Case 2: Toggling Private window with Tor to Off - PASSED

Confirmed when Private window with Tor is disabled, Automatically redirect .onion sites and Use Bridges are disabled

Case 3: Enabling Use Bridges should expand to additional settings - PASSED

Confirmed toggling Use Bridges to Enabled expands to the following three radio-button options:

• Select a built-in bridge with obfs4 selected
• Request a bridge from torproject.org w/read-only textfield and Request a New Bridge... button
• Provide a bridge with input textfield
  also confirmed toggling it to Disabled collapses it to its original state

Case 4: Apply changes button should be dynamic - PASSED

Confirmed the following:

• the Apply changes button appears after changing input values and/or radio-button selections (with input)
• after clicking Apply changes, the button disappears until another change is made
• the Apply changes button correctly disappears if a value was changed (to trigger the button) but not /applied/, and then reverted to its original value

Select a built-in-bridge	Request a bridge from torproject.org	Provide a bridge

Bridges (basic)

Case 1: Built-in bridges listing - PASSED

Confirmed built-in bridges are the following, in order:

• obfs4
• Snowflake
• meek-azure

Case 2: Built-in bridges functionality - `PASSED`

#### Confirmed the steps below with each of the following built-in bridges:

• obfs4
• Snowflake
• meek-azure

1. selected a bridge
2. clicked on Apply changes
3. clicked on "hamburger menu" -> New private window with Tor
4. confirmed I could load check.torproject.org
5. double-confirmed by clicking on New Tor connection for this site, and ensuring it reloads

obfs4	Snowflake	meek-azure

Case 3: Request a bridge from torproject.org - PASSED

#### Confirmed the following:

• empty, read-only textfield
• placeholder text on selection reads Click on "Request a New Bridge..." to get bridges
• clicking on the Request a bridge from torproject.org radio button enables the Request a New Bridge... button
• clicking the Request a New Bridge button displays a Request Bridge CAPTCHA dialog

Request a bridge from... radio button	Request a New Bridge... button

Case 3.5: Request Bridge CAPTCHA dialog - PASSED

Confirmed the following:

• X dismisses the dialog
• Cancel dismisses the dialog
• clicking the Renew button refreshes the CAPTCHA
• invalid input refreshes the CAPTCHA
• CAPTCHA solves are case-insensitive
• valid CAPTCHA submission dismisses the dialog and populates the read-only textarea with valid obfs4 bridges (obfs4 xxx.xxx.xxx:xxxx... lines)

Renew button	invalid input	valid obfs4 bridges

Case 4: Provide a bridge - PASSED

#### Confirmed the following:

• empty input textarea
• placeholder text on selection reads Type address:port (one per line)
• used previous config from Request a Bridge... test
• also used configs generated from https://bridges.torproject.org/options/

focused/selected	check.torproject.org

Bridges (detailed)

Case 1: Brave Tor Client Updater component - PASSED

• opened brave://components
• launched New private window with Tor
• confirmed Brave Tor Client Updater appears
• confirmed new 1.0.28 version (previous ``)

Case 2: Brave Pluggable Transports component - PASSED

opened brave://settings/privacy
clicked to toggle Use Bridges to Enabled
clicked Apply changes
opened brave://components
confirmed new Brave Pluggable Transports (Mac) appears
noted version 1.0.0

Case 3: Specific transport-binary processes - PASSED

obfs4

• continued from the above testcase
• in brave://settings/privacy, chose obfs4
• clicked Apply changes
• opened a New private window with Tor
• loaded check.torproject.org
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-obfs4-brave

Snowflake

• in brave://settings/privacy, chose Snowflake
• clicked Apply changes
• opened a New private window with Tor
• loaded check.torproject.org
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-snowflake-brave

meek-azure

• in brave://settings/privacy, chose meek-azure
• clicked Apply changes
• opened a New private window with Tor
• opened the OS Task Manager, and confirmed the process name

brave://settings/privacy	check.torproject.org	tor-obfs4-brave

Logged:

• Tor connection failed using meek-azure bridge #25535

Case 4: Disabling bridges should stop processes and remove components from profile - PASSED

• ran through the above cases for each bridge type again, as setup
• toggled Use Bridges to Disabled
• clicked Apply changes
• examined: Activity Monitor and {user dir} for

Confirmed:

• no bridge-specific processes still running
• bridge-transport component directory

Running bridges

obfs4	Snowflake	meek-azure

Disabled bridges

obfs4	Snowflake	meek-azure

Case 5: Changing bridge settings should renew IP address - PASSED

• toggled Use Bridges to Enabled on brave://settings/privacy
• clicked Apply changes
• clicked on "hamburger menu" -> New private window with Tor
• loaded yandex.com/internet
• noted the IP address - 185.195.71.3
• selected a new bridge type on brave://settings/privacy
• clicked Apply changes
• reload the yandex.com/internet tab
• noted the IP address

Confirmed I was assigned a new IP address 184.75.221.59

, replacing 185.195.71.3 after changing bridge types from obfs4 to Snowflake

obfs4 bridge	obfs4 IP	Snowflake bridge	Snowflake IP

Case 6: Bad bridge config - PASSED

• in brave://settings/privacy, pasted obfs4 99.124.226.90:9998 8BFDDB7D7D2D4BDD4169170C818B175C6B60F799 cert=fmp+hf7s1QH6Crg+FW39P5KTxy57NCfXs+t1vBrNuYrHGebGtbRrdkKfk+pcgZhBdbrVcw iat-mode=0 (from the provided https://github.com/brave/brave-core/pull/13290#issue-1232508125) into the Provide a bridge textarea
• clicked Apply changes
• clicked "hamburger menu" -> New private window with Tor
• loaded brave.com
• waited

Confirmed I got the Tor connection failed error message

• clicked on the Brave Settings and bridges links, which go to brave://settings/privacy
• clicked on the contact support link and confirmed it loaded https://support.brave.com/hc/en-us in a new tab

brave://settings/privacy	Tor connection failed	support.brave.com