Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase view from 7-day ad history to 30-day ad history #16627

Closed
Miyayes opened this issue Jun 26, 2021 · 6 comments · Fixed by brave/brave-core#9300
Closed

Increase view from 7-day ad history to 30-day ad history #16627

Miyayes opened this issue Jun 26, 2021 · 6 comments · Fixed by brave/brave-core#9300

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 26, 2021

Description

Currently, ad history contains up to 7 days of ads. This should be increased to 30 days.

Solution

  • Increase ad history list to contain 30 days of history.
  • Change hyperlink text as needed

cc: @tmancey @lukemulks

@himanshu007-creator
Copy link

Hi, I would like to work on this issue. Please guide me further where to make changes.
BTW i am really enjoying Brave🎉

@enxio27
Copy link

enxio27 commented Jun 28, 2021

This is a great idea! It will help a lot with trouble-shooting. Please also extend this feature to Android.

@tmancey
Copy link
Contributor

tmancey commented Jul 1, 2021

@himanshu007-creator That's great you are enjoying Brave. Apologies, I just noticed you would have liked to work on this.

@himanshu007-creator
Copy link

@himanshu007-creator That's great you are enjoying Brave. Apologies, I just noticed you would have liked to work on this.

Nevermind, I'll find some other low hanging fruit (easy issue)🙂

@stephendonner
Copy link

Setting as QA/Blocked because we should wait to verify after brave/brave-core#9543 lands in 1.28.x; without that fix, days are capped at 7 (not just a cosmetic UI change 👍 ).

@stephendonner stephendonner added QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Jul 28, 2021
@stephendonner
Copy link

Verified FIXED using the testplan from brave/brave-core#9300 with build

Brave 1.28.96 Chromium: 92.0.4515.115 (Official Build) beta (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)

Also used for the migration cases were

Brave 1.27.109 Chromium: 92.0.4515.115 (Official Build) (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)
Brave 1.26.77 Chromium: 91.0.4472.164 (Official Build) (x86_64)
Revision 541163496c9982c98f61819bab7cf2183ea8180f-refs/branch-heads/4472@{#1569}
OS macOS Version 11.5.1 (Build 20G80)

1.28.96:

Steps:

  1. new profile
  2. launched Brave
  3. enabled Rewards
  4. viewed ads
  5. loaded brave://rewards
  6. confirmed it says 30-day Ads History and lists my ads
  7. click on the above link
  8. confirmed the popup reads Ads you've received in the past 30 days
  9. shut down Brave
  10. forwarded system clock 30 days
  11. launched Brave
  12. confirmed there's no ad history
  13. shut down Brave
  14. from today's date, forwarded system clock 29 days
  15. launched Brave
  16. confirmed 30-day ads history returned
steps 6-8 steps 6-8 step 12 step 16 step 16
Screen Shot 2021-07-29 at 12 41 56 PM Screen Shot 2021-07-29 at 12 42 00 PM Screen Shot 2021-07-29 at 2 11 00 PM Screen Shot 2021-07-29 at 12 41 56 PM Screen Shot 2021-07-29 at 12 42 00 PM

1.27.109 and 1.26.77:

Steps (for both):

  1. new profile
  2. launched Brave
  3. enabled Rewards
  4. viewed ads
  5. loaded brave://rewards
  6. confirmed it says 7-day Ads History and lists my ads
  7. upgraded builds to 1.28.96
  8. launched Brave
  9. loaded brave://rewards
  10. confirmed and clicked on the 30-day Ads History link
  11. confirmed it says 30-day Ads History and lists my ads
step 6 step 6 step 10 step 11
Screen Shot 2021-07-29 at 12 40 25 PM Screen Shot 2021-07-29 at 12 40 28 PM Screen Shot 2021-07-29 at 12 49 28 PM Screen Shot 2021-07-29 at 12 49 31 PM

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 29, 2021
@rebron rebron changed the title Increase 7-day ad history to 30-day ad history Increase view from 7-day ad history to 30-day ad history Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment