Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bookmarks folder icon on the bookmarks bar #16940

Closed
simonhong opened this issue Jul 14, 2021 · 1 comment · Fixed by brave/brave-core#9424
Closed

Update bookmarks folder icon on the bookmarks bar #16940

simonhong opened this issue Jul 14, 2021 · 1 comment · Fixed by brave/brave-core#9424

Comments

@simonhong
Copy link
Member

This issue is only for bookmarks bar folder image and is sub issue of #7312

@stephendonner
Copy link

stephendonner commented Jul 20, 2021

Verified PASSED using

Brave 1.28.85 Chromium: 92.0.4515.93 (Official Build) beta (x86_64)
Revision 6eb43ff7850a1d710c3f827a0555737c74edab5c-refs/branch-heads/4515@{#1378}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. either populate or import bookmarks, and ensure View | Always show bookmarks is toggled to On
  4. look at the bookmarks bar's folder icons
  5. confirmed the icons were new and matched the style over in Replaced folder image from bookmarks bar brave-core#9424

light

before after
Screen Shot 2021-07-19 at 5 24 00 PM Screen Shot 2021-07-19 at 5 24 09 PM

dark

before after
Screen Shot 2021-07-19 at 5 24 23 PM Screen Shot 2021-07-19 at 5 24 37 PM

Verification passed on


Brave | 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
-- | --
Revision | 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS | Windows 10 OS Version 2004 (Build 19041.1110)

  • Confirmed bookmarks folders icon/image changed to brave branded icon

Light theme
image

Dark theme
image

  • Confirmed subfolder icon/images are changed to brave branded icon

Light theme
image

Dark theme
image


Verification passed on

Brave 1.28.92 Chromium: 92.0.4515.107 (Official Build) beta (64-bit)
Revision 87a818b10553a07434ea9e2b6dccf3cbe7895134-refs/branch-heads/4515@{#1634}
OS Ubuntu 18.04 LTS

Verified expected behavior from brave/brave-core#9424

  • Confirmed bookmarks folders icon/image changed to brave branded icon

Light theme
image

Dark theme
image

  • Confirmed subfolder icon/images are changed to brave branded icon

Light theme
image

Dark theme
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment