Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to migrate from go-ipfs 0.7.0 to latest (0.9.1) #18253

Closed
stephendonner opened this issue Sep 21, 2021 · 2 comments
Closed

Unable to migrate from go-ipfs 0.7.0 to latest (0.9.1) #18253

stephendonner opened this issue Sep 21, 2021 · 2 comments

Comments

@stephendonner
Copy link

stephendonner commented Sep 21, 2021

Description

Unable to migrate from go-ipfs 0.7.0 to latest (0.9.1)

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. visit brave://ipfs
  4. click on Install and start
  5. confirm you have go-ipfs 0.9.1 installed
  6. shut down Brave
  7. delete the brave_ipfs directory in your top-level user profile
  8. rename go-ipfs_v0.9.1_darwin-am64 to go-ipfs_v0.9.1_darwin-am64.ORIG in /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.6
  9. grab and expand the tarred go-ipfs 0.7.0 binary from https://github.com/ipfs/go-ipfs/releases/tag/v0.7.0
  10. drop the 0.7.0 binary into /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.6
  11. restart Brave
  12. confirm Brave is running go-ipfs 0.7.0
  13. on brave://ipfs click the Restart button a few times

Actual result:

It doesn't automatically upgrade to go-ipfs 0.9.1

stephendonner@Stephens-MacBook-Pro MacOS % ./Brave\ Browser --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
[1799:259:0921/114235.231098:WARNING:external_provider_impl.cc(484)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[1799:259:0921/114235.231327:VERBOSE1:ads_service_impl.cc(1465)] Migrating ads preferences
[1799:259:0921/114235.231372:VERBOSE2:ads_service_impl.cc(1492)] Ads preferences are up to date on version 11
[1799:259:0921/114240.703327:WARNING:CONSOLE(1)] "no tab id so cannot request shield data from window focus change!", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1799:259:0921/114240.720462:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data for tabId: 2.  Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1799:259:0921/114240.720947:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data for tabId: 2.  Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1799:259:0921/114240.721029:ERROR:CONSOLE(1)] "[Shields]: Can't request shields panel data for tabId: 2.  Error: No tab url specified", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1799:259:0921/114240.774378:WARNING:CONSOLE(226)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data.js (226)
[1799:259:0921/114243.478730:VERBOSE1:ads_service_impl.cc(652)] Successfully migrated confirmations state
[1799:28419:0921/114243.535033:ERROR:chrome_browser_main_extra_parts_metrics.cc(228)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
[1799:28419:0921/114243.536077:ERROR:chrome_browser_main_extra_parts_metrics.cc(231)] crbug.com/1216328: Checking Bluetooth availability ended.
[1799:28419:0921/114243.536147:ERROR:chrome_browser_main_extra_parts_metrics.cc(234)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
[1799:28419:0921/114243.536298:ERROR:chrome_browser_main_extra_parts_metrics.cc(238)] crbug.com/1216328: Checking default browser status ended.
[1799:259:0921/114244.549397:WARNING:CONSOLE(226)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data.js (226)
[1799:259:0921/114244.701186:INFO:CONSOLE(3093)] "setting today viewport observer, should only happen once", source: chrome://newtab/brave_new_tab.bundle.js (3093)
[1799:259:0921/114301.543152:WARNING:CONSOLE(226)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data.js (226)
generating ED25519 keypair...done
peer identity: 12D3KooWDyfEoEtjxFSqv6kwxr4r1KYDzpzeLBBP5fKEkgLyBwMK
initializing IPFS node at /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
to get started, enter:

	ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

Error: daemon not running
Initializing daemon...
go-ipfs version: 0.9.1
Repo version: 11
System version: amd64/darwin
Golang version: go1.16.6
Swarm listening on /ip4/10.0.0.25/tcp/44005
Swarm listening on /ip4/127.0.0.1/tcp/44005
Swarm listening on /ip6/::1/tcp/44005
Swarm listening on /p2p-circuit
Swarm announcing /ip4/10.0.0.25/tcp/44005
Swarm announcing /ip4/127.0.0.1/tcp/44005
Swarm announcing /ip6/::1/tcp/44005
API server listening on /ip4/127.0.0.1/tcp/45005
WebUI: http://127.0.0.1:45005/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48084
Daemon is ready

Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)
stephendonner@Stephens-MacBook-Pro MacOS % ./Brave\ Browser --enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
[1863:259:0921/114459.963670:WARNING:external_provider_impl.cc(484)] Malformed extension dictionary for extension: odbfpeeihdkbihmopkbjmoonfanlbfcl.  Key external_update_url has value "", which is not a valid URL.
[1863:259:0921/114459.963905:VERBOSE1:ads_service_impl.cc(1465)] Migrating ads preferences
[1863:259:0921/114459.963943:VERBOSE2:ads_service_impl.cc(1492)] Ads preferences are up to date on version 11
[1863:259:0921/114500.674694:WARNING:CONSOLE(226)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data.js (226)
[1863:259:0921/114500.756908:WARNING:CONSOLE(1)] "no tab id so cannot request shield data from window focus change!", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)
[1863:259:0921/114502.637764:VERBOSE1:ads_service_impl.cc(652)] Successfully migrated confirmations state
[1863:36099:0921/114502.670741:ERROR:chrome_browser_main_extra_parts_metrics.cc(228)] crbug.com/1216328: Checking Bluetooth availability started. Please report if there is no report that this ends.
[1863:36099:0921/114502.671646:ERROR:chrome_browser_main_extra_parts_metrics.cc(231)] crbug.com/1216328: Checking Bluetooth availability ended.
[1863:36099:0921/114502.671690:ERROR:chrome_browser_main_extra_parts_metrics.cc(234)] crbug.com/1216328: Checking default browser status started. Please report if there is no report that this ends.
[1863:36099:0921/114502.671828:ERROR:chrome_browser_main_extra_parts_metrics.cc(238)] crbug.com/1216328: Checking default browser status ended.
[1863:259:0921/114506.884160:INFO:ipfs_service.cc(275)] Failed to launch IPFS
generating ED25519 keypair...done
peer identity: 12D3KooWP15cX6wvHNRDwJiRSKsxzNkfhrKUAvNNEWiL6dPUHi7B
initializing IPFS node at /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/brave_ipfs
to get started, enter:

	ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

Error: daemon not running
Initializing daemon...
go-ipfs version: 0.7.0
Repo version: 10
System version: amd64/darwin
Golang version: go1.14.4
Swarm listening on /ip4/10.0.0.25/tcp/44005
Swarm listening on /ip4/127.0.0.1/tcp/44005
Swarm listening on /ip6/::1/tcp/44005
Swarm listening on /p2p-circuit
Swarm announcing /ip4/10.0.0.25/tcp/44005
Swarm announcing /ip4/127.0.0.1/tcp/44005
Swarm announcing /ip6/::1/tcp/44005
API server listening on /ip4/127.0.0.1/tcp/45005
WebUI: http://127.0.0.1:45005/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48084
Daemon is ready

Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)
Error: daemon not running
Initializing daemon...
go-ipfs version: 0.7.0
Repo version: 10
System version: amd64/darwin
Golang version: go1.14.4
Swarm listening on /ip4/10.0.0.25/tcp/44005
Swarm listening on /ip4/127.0.0.1/tcp/44005
Swarm listening on /ip6/::1/tcp/44005
Swarm listening on /p2p-circuit
Swarm announcing /ip4/10.0.0.25/tcp/44005
Swarm announcing /ip4/127.0.0.1/tcp/44005
Swarm announcing /ip6/::1/tcp/44005
API server listening on /ip4/127.0.0.1/tcp/45005
WebUI: http://127.0.0.1:45005/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48084
Daemon is ready
[1863:259:0921/114732.291951:WARNING:CONSOLE(226)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data.js (226)

Received interrupt signal, shutting down...
(Hit ctrl-c again to force-shutdown the daemon.)
Error: daemon not running
Initializing daemon...
go-ipfs version: 0.7.0
Repo version: 10
System version: amd64/darwin
Golang version: go1.14.4
Swarm listening on /ip4/10.0.0.25/tcp/44005
Swarm listening on /ip4/127.0.0.1/tcp/44005
Swarm listening on /ip6/::1/tcp/44005
Swarm listening on /p2p-circuit
Swarm announcing /ip4/10.0.0.25/tcp/44005
Swarm announcing /ip4/127.0.0.1/tcp/44005
Swarm announcing /ip6/::1/tcp/44005
API server listening on /ip4/127.0.0.1/tcp/45005
WebUI: http://127.0.0.1:45005/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48084
Daemon is ready

Expected result:

Should automatically upgrade to go-ipfs 0.9.1

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.30.81 Chromium: 94.0.4606.50 (Official Build) (x86_64)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS macOS Version 11.6 (Build 20G165)

/cc @spylogsster @lidel

@spylogsster
Copy link

spylogsster commented Oct 1, 2021

@stephendonner the updater looks at extension version, in order to get update please add a couple of changes:

  1. /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.6 rename folder to /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.5
  2. Change version in /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser/nljcddpbnaianmglkpkneakjaapinabi/1.0.5/manifest.json to 1.0.5 and start the browser.

@stephendonner
Copy link
Author

Verified works for me, now, with the two renaming tasks, above, done.

Brave 1.30.87 Chromium: 94.0.4606.71 (Official Build) (x86_64)
Revision 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS macOS Version 11.6 (Build 20G165)

Screen Shot 2021-10-04 at 3 07 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants