Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment between radio buttons and their labels is off #23097

Closed
stephendonner opened this issue May 27, 2022 · 2 comments · Fixed by brave/brave-core#16178
Closed

Alignment between radio buttons and their labels is off #23097

stephendonner opened this issue May 27, 2022 · 2 comments · Fixed by brave/brave-core#16178

Comments

@stephendonner
Copy link

stephendonner commented May 27, 2022

Description

Alignment between radio buttons and their labels is off

Steps to Reproduce

  1. install 1.41.19
  2. launch Brave
  3. set up VPN
  4. click on the VPN button and ensure you're connected
  5. click on the currently-connected region link (in my case, USA (West) >

Actual result:

example example example example
Screen Shot 2022-05-26 at 3 37 55 PM Screen Shot 2022-05-26 at 11 53 25 PM Screen Shot 2022-05-26 at 3 37 48 PM Screen Shot 2022-05-26 at 11 53 09 PM

Expected result:

Better vertical alignment

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.19 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 11.6.6 (Build 20G624)

cc @nullhook @aguscruiz @spylogsster @bsclifton @srirambv

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 9, 2022

Verification PASSED on

Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 10 Version 21H2 (Build 19044.2251)

  • Verified the STR from the description
    • Ensured that the alignment between the flags and their country names is now fixed
example example example example
image image image image

@GeetaSarvadnya GeetaSarvadnya removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 9, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.141 Chromium: 108.0.5359.99 (Official Build) (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)
example example example example
Screenshot 2022-12-09 at 12 40 08 PM Screenshot 2022-12-09 at 12 40 51 PM Screenshot 2022-12-09 at 12 40 20 PM Screenshot 2022-12-09 at 12 40 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment