Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy edit on Brave Wallet / crypto / accounts: web 3 to web3 #23328

Closed
lukemulks opened this issue Jun 8, 2022 · 2 comments · Fixed by brave/brave-core#13754
Closed

Copy edit on Brave Wallet / crypto / accounts: web 3 to web3 #23328

lukemulks opened this issue Jun 8, 2022 · 2 comments · Fixed by brave/brave-core#13754
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@lukemulks
Copy link

lukemulks commented Jun 8, 2022

Description

On brave://wallet/crypto/accounts, within the Primary crypto accounts section copy, we have a space between web and 3 in web 3.

sample of section copy in current form:

These accounts can be used with web 3 DApps, and can be shown in your portfolio. However, note that secondary accounts cannot be restored via recovery phrase from your primary account backup.

Suggest we update from web 3 to web3, removing the extra space between web and 3.

stylized web3 adopted as common shortform nomenclature in blockchain space, across b2c, p2p and b2b.

Steps to Reproduce

  1. navigate to brave://wallet/crypto/accounts
  2. section: Primary crypto accounts
  3. observe: These accounts can be used with web 3 DApps...

Actual result:

web 3

Expected result:

web3

Reproduces how often:

100%

Brave version (info found on brave://version)

1.41.33 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? y
  • Can you reproduce this issue with the beta channel? y
  • Can you reproduce this issue with the dev channel? unknown; tbd.
  • Can you reproduce this issue with the nightly channel? y

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

Heya @jamesmudgett @Douglashdaniel @onyb given this is a single-character string update, grouped you all on this one in case it's able to be attached to any uplifts, etc.

note - I have only checked on desktop so far. that said, iirc Android on core, so would suspect that this likely applies there as well; unclear on iOS, and don't have an iOS device nearby that I can check from (so someone on iOS should spot check)

@lukemulks lukemulks added bug feature/web3/wallet Integrating Ethereum+ wallet support labels Jun 8, 2022
@jamesmudgett
Copy link

Yup, should also be capitalized Web3

@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2022

Brave 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13754
  • Verified Web 3 is changed to Web3
  • Verified primary and secondary accounts description is shown correctly
Welcome screen
Import from MetaMask
Import from CryptoWallets
Welcome panel
Default Wallet warning banner
Accounts tab (Secondary Accounts description)
Import Account modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants