Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Solana DApps support by default on desktop #23520

Closed
darkdh opened this issue Jun 16, 2022 · 3 comments · Fixed by brave/brave-core#13825 or brave/brave-core#13994
Closed

Enable Solana DApps support by default on desktop #23520

darkdh opened this issue Jun 16, 2022 · 3 comments · Fixed by brave/brave-core#13825 or brave/brave-core#13994
Assignees
@darkdh
Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Jun 16, 2022

It will remain disabled by default on Android.
Also need to aggregate test plans for all the API
@darkdh darkdh self-assigned this Jun 16, 2022
@darkdh darkdh mentioned this issue Jun 16, 2022
Merged
25 tasks
@darkdh darkdh added this to the 1.42.x - Nightly milestone Jun 22, 2022
@stephendonner stephendonner changed the title Enable Solana dApps support by default on desktop Enable Solana DApps support by default on desktop Jun 23, 2022
@yrliou
Copy link
Member

yrliou commented Jun 28, 2022

Reverted by brave/brave-core#13981 due to recent crashes in nightly.

@yrliou yrliou reopened this Jun 28, 2022
@yrliou yrliou removed this from the 1.42.x - Nightly milestone Jun 28, 2022
@darkdh darkdh mentioned this issue Jun 28, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 28, 2022
@darkdh darkdh mentioned this issue Jun 29, 2022
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Jul 2, 2022

The above will require 1.41.89 or higher for 1.41.x verification 👍

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 5, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#13825
  • Verified Solana Dapp support is enabled by default
  • Verified able to connect to Dapps using Solana account and perform Sign/Transactions
Transactions Verified as part of #23369 (comment). Also verified on RC build and seems to work fine
Account Connect & Disconnect
23520.-.Connect.Disconnect.mp4
23520.-.Connect.Disconnect.mp4
23250.-.Connect.Disconnect.mov
Account Connect & Lock
23520.-.Connect.Lock.mp4
23520.-.Connect.Lock.mp4
23250.-.Connect.Lock.mov
Sign Messages
23520-Sign.Messages.mp4
23520.-.Sign.Messages.mp4
23250.-.Sign.Messages.mov
Account Change Event
23520-Account.Change.mp4
23520.-.Account.Changed.mp4
23250.-.Account.Change.mov

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet/dapps feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
6 participants
@kjozwiak @yrliou @darkdh @srirambv @LaurenWags @brave-builds