Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hackerone] dev tool console leak in Tor window #23579

Closed
darkdh opened this issue Jun 21, 2022 · 4 comments · Fixed by brave/brave-core#13887
Closed

[hackerone] dev tool console leak in Tor window #23579

darkdh opened this issue Jun 21, 2022 · 4 comments · Fixed by brave/brave-core#13887

Comments

@darkdh
Copy link
Member

darkdh commented Jun 21, 2022

https://hackerone.com/reports/1605654

@kjozwiak
Copy link
Member

The above will require 1.41.80 or higher for 1.41.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.80 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

First, confirmed issue using 1.40.105

example example
Screen Shot 2022-06-27 at 12 45 54 PM Screen Shot 2022-06-27 at 12 46 12 PM

Steps:

  1. installed 1.41.80
  2. clicked on the "hamburger" menu
  3. clicked on New Private Window with Tor
  4. opened Developer Tools
  5. clicked on the Console panel
  6. typed a=123 and pressed return
  7. clicked on the "hamburger" menu
  8. clicked on "New Window"
  9. clicked on the Console panel
  10. pressed the arrow-up key ⬆️

Confirmed no history of previous entry shown

example example
Screen Shot 2022-06-27 at 12 35 07 PM Screen Shot 2022-06-27 at 12 35 34 PM

@stephendonner
Copy link

stephendonner commented Jun 27, 2022

Verified PASSED using

Brave 1.41.80 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Linux

Steps:

  1. installed 1.41.80
  2. clicked on the "hamburger" menu
  3. clicked on New Private Window with Tor
  4. opened Developer Tools
  5. clicked on the Console panel
  6. typed a=123 and pressed return
  7. clicked on the "hamburger" menu
  8. clicked on "New Window"
  9. clicked on the Console panel
  10. pressed the arrow-up key ⬆️

Confirmed no history of previous entry shown

example example
Screen Shot 2022-06-27 at 1 47 47 PM Screen Shot 2022-06-27 at 1 48 07 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.41.86 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
-- | --
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Windows 11 Version 21H2 (Build 22000.739)

Reproduced the issue in 1.40.109

TOR window Normal window
image image

Steps:

  1. installed 1.41.86
  2. clicked on the "hamburger" menu
  3. clicked on New Private Window with Tor
  4. opened Developer Tools
  5. clicked on the Console panel
  6. typed a=123 and pressed return
  7. clicked on the "hamburger" menu
  8. clicked on "New Window"
  9. clicked on the Console panel
  10. pressed the arrow-up key ⬆️

Confirmed no history of previous entry shown

TOR window Normal window
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment