Remove Block all text when there are no entries - follow up to 1906

[LaurenWags]

Description

Issue #1906 was not resolved, logging this follow up issue.

Remove Block all text when there are no entries

Steps to Reproduce

1. Build from master or run 0.57.16.
2. Visit a site. Enable Scripts Blocked (text is also a little confusing) @karenkliu relating to the conversation on Shields v2 GA version brave-extension#70 (comment)
3. Click on the expand button to see the items blocked
4. Block all text is shown even though there are no items under allowed list

Actual result:

Expected result:

Should not have unwanted text which is confusing

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @rebron since this was originally slated for 0.57.x but was not resolved.
cc @brave/legacy_qa

[cezaraugusto]

cc @karenkliu agree on this?

[karenkliu]

@cezaraugusto Yes, correct.

[karenkliu]

Hi @cezaraugusto, just noting that this issue is still open:

[rebron]

Closing as stale/wontfix.