YouTube ad's are not blocked sometimes

[srirambv]

Description

YouTube ad's are not blocked sometimes

Steps to Reproduce

1. Build from source
2. Watch YouTube videos
3. Some ads leak through either as pre-roll or in between stream

Actual result:

Expected result:

All YouTube ads should be blocked

Reproduces how often:

Easy(just need to keep watching YT)

Brave version (about:brave info)

2e9c470

[bbondy]

Does it work differently from browser-laptop?

[srirambv]

Yes. No pre-roll ad or instream ads are seen on browser-laptop. Once it starts doesn't stop. Have to clear browsing history and start over for it to start blocking ads

[emerick]

@srirambv Could you give this another try please? I believe an erroneous file was on our S3 server. If by chance you continue to see the problem, it would be helpful to capture the chrome_debug.log and a screenshot of chrome://components/ as well if possible. Thanks!

[srirambv]

@emerick Not seeing on a clean profile built from 332140d. Closing the issue for now. If it reproduces will capture the details and reopen the issue.

[bbondy]

🎉

[emerick]

Thanks @srirambv!

[srirambv]

Verification Passed on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

• No pre-roll ads seen on YT before playback
• No in video ads seen on YT while playback

Verification passes on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X