Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'Show Brave Rewards icon in...' toggle to BR pane so all BR related controls are in one place #24204

Closed
jenn-rhim opened this issue Jul 21, 2022 · 4 comments · Fixed by brave/brave-core#14557

Comments

@jenn-rhim
Copy link

image

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 25, 2022

One funny edge case is this:

If user has not yet enabled Brave Rewards, then this is what the Brave Rewards section of brave://settings looks like:

image

So, they wouldn't be able to access it without first enabling Brave Rewards (which they might not want to do).

That said, maybe that's acceptable now that we introduced a right-click hide on the BAT icon itself?

@jenn-rhim ^^

@rebron
Copy link
Collaborator

rebron commented Jul 25, 2022

@Miyayes The show/hide Brave Rewards icon setting could still live separately in the Brave Rewards section when Brave Rewards are disabled. Could have the setting sit on top or below what's shown there.

@Miyayes
Copy link
Collaborator

Miyayes commented Jul 25, 2022

@Miyayes The show/hide Brave Rewards icon setting could still live separately in the Brave Rewards section when Brave Rewards are disabled. Could have the setting sit on top or below what's shown there.

That's a good point. We will plop it in as an item under the "Brave Rewards are disabled" section, then. Thanks!

@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 2, 2022

Verification PASSED using

Brave | 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
-- | --
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS | Windows 11 Version 21H2 (Build 22000.856)

Case 1: Rewards disabled - PASSED

Clean profile:

  1. Install 1.44.73
  2. launch Brave
  3. Do not enable rewards
  4. open brave://settings/rewards

Confirmed Show Brave Rewards icon in address bar setting shown in brave://settings/rewards and the ON/OFF toggle functionality works as expected

toggle OFF toggle ON
image image

Upgrade Upgrade 1.43.88-->1.44.73

  1. Install 1.43.88
  2. enable Rewards
  3. Show Brave Rewards icon in address bar is available and enabled in brave://settings/appearance
  4. toggle OFF for Show Brave Rewards icon in address bar
  5. close the browser
  6. rename profile
  7. install 1.44.73
  8. launch Brave
  9. open brave://settings/rewards

Confirmed Show Brave Rewards icon in address bar setting shown in brave://settings/rewards and the toggle 'OFF` setting retained.

Step 3 Step 4 Step 9
image image image

Case 2: Rewards enabled - PASSED

Clean profile

  1. clean profile
  2. enable Rewards
  3. open brave://settings/rewards

Confirmed Show Brave Rewards icon in address bar setting shown in brave://settings/rewards and the ON/OFF toggle functionality works as expected

toggle ON toggle OFF
image image

Upgrade 1.43.88-->1.44.73 - PASSED

  1. Install 1.43.88
  2. Enable Rewards
  3. Show Brave Rewards icon in address bar is available and enabled in brave://settings/appearance`
  4. leave toggle ON for Show Brave Rewards icon in address bar
  5. close the browser
  6. rename profile
  7. install 1.44.73
  8. launch Brave
  9. open brave://settings/rewards

Confirmed Show Brave Rewards icon in address bar setting moved from brave://settings/appearance to brave://settings/rewards and the toggle 'ON` setting retained.

Step 3 Step 9
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants