Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2 BAT minimum threshold for connecting/verifying with Uphold #24759

Closed
Miyayes opened this issue Aug 18, 2022 · 3 comments · Fixed by brave/brave-core#14872
Closed

Remove 2 BAT minimum threshold for connecting/verifying with Uphold #24759

Miyayes opened this issue Aug 18, 2022 · 3 comments · Fixed by brave/brave-core#14872
Assignees

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Aug 18, 2022

Description

Remove 2 BAT minimum threshold for connecting/verifying with Uphold.

@kjozwiak
Copy link
Member

The above will require 1.44.83 or higher for 1.44.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 13, 2022

Verification PASSED on


Brave | 1.44.83 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Went through the Uphold login process on a new profile and ensured there weren't any errors indicating that 2 BAT was needed before being able to signup for an account as per the following:

Example Example Example Example Example Example
image image image image image image

Also ensured that you can login into previously created accounts without any issues.

@stephendonner
Copy link

Verified PASSED using 1.44.86, Chromium 105.0.5195.127 on a Google Pixel XL running Android 9.0.

First, reproduced the issue in current 1.43.89:

example example
Screenshot_20220915-155049 Screenshot_20220915-155746

Steps:

  1. install 1.44.86
  2. launch Brave
  3. enable Rewards
  4. on brave://rewards, tap on Unverified
  5. tap Continue
  6. note no message about the 2-BAT-minimum requirement
  7. also completed logging in/verifying my Uphold account, on staging, as a regression test
example example example
Screenshot_20220915-155049 Screenshot_20220915-155055 (1) Screenshot_20220915-162228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants