Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use host name for default sync device name #2573

Closed
darkdh opened this issue Dec 14, 2018 · 1 comment · Fixed by brave/brave-core#1136
Closed

Use host name for default sync device name #2573

darkdh opened this issue Dec 14, 2018 · 1 comment · Fixed by brave/brave-core#1136

Comments

@darkdh
Copy link
Member

darkdh commented Dec 14, 2018

Instead of displaying Mac/Linux/Windows Desktop, we should use these API to get hostname info

http://man7.org/linux/man-pages/man2/gethostname.2.html
https://docs.microsoft.com/en-us/windows/desktop/api/winsock/nf-winsock-gethostname

@srirambv
Copy link
Contributor

srirambv commented Jan 8, 2019

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux
  • New sync chain adds device name automatically

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10
  • New sync chain adds device name automatically

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X
  • Verified host name is used by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment