Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] 0.58.x sync issues that still need to be verified (Windows only) #2672

Closed
LaurenWags opened this issue Dec 20, 2018 · 4 comments
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 20, 2018

Because it was decided that sync won't be going out enabled by default in 0.58.x, QA concentrated on verifying other issues. Because the following PR/fixes already landed in 0.58.x, we need to verify that the following have also been QA'd/verified for sync on Windows:

This issue is specific to Windows, however CCing @brave/legacy_qa please let me know if there's anything that I might have missed.

@btlechowski
Copy link

Verified all except #2552 and #2533 which were moved to 0.60.x

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

@btlechowski looks like brave/brave-core#1191 landed in 0.59.x about a day ago but the milestones for #2533, #2552, #2728, #2737 weren't updated and the issues were still in 0.60.x. I moved #2533, #2552, #2728, #273 into 0.59.x 👍

We should be able to QA #2552 & #2533 as brave/brave-core#1191 landed in 0.59.18. Clearing the flag until #2552 & #2533 are checked.

@btlechowski
Copy link

@kjozwiak I think this issue is only for issues that were closed in 0.58.x milestone. We couldn't move them to 0.59.x milestone, hence this issue was created.

This issue is not for sync issues that have 0.59.x milestone.

@kjozwiak
Copy link
Member

kjozwiak commented Jan 4, 2019

@btlechowski yup, you're right 👍 Lets just remove #2552 & #2533 form the above list and those can be addressed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants