Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "Copy clean link" menu from the App menu #27676

Closed
sangwoo108 opened this issue Jan 6, 2023 · 6 comments · Fixed by brave/brave-core#16274
Closed

Support "Copy clean link" menu from the App menu #27676

sangwoo108 opened this issue Jan 6, 2023 · 6 comments · Fixed by brave/brave-core#16274
Assignees
@spylogsster
Labels
closed/duplicate Issue has already been reported copy-clean-link OS/Desktop OS/macOS QA/No release-notes/exclude
Milestone
1.49.x - Release

Comments

@sangwoo108
Copy link

When users select URL on the web page, text editing menu items are enabled, such as "copy", and "paste" and etc. In this case, we might be able to insert "Copy clean link"

Screen Shot 2023-01-04 at 3 37 25 PM
@sangwoo108 sangwoo108 mentioned this issue Jan 6, 2023
Merged
25 tasks
@rebron
Copy link
Collaborator

rebron commented Jan 6, 2023

cc: @fmarier

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 6, 2023
@fmarier
Copy link
Member

fmarier commented Jan 6, 2023

This also applies to the contextual menu on Windows/Linux. There is code that detects URLs and triggers the "Go to URL" menu item for example when a URL is selected:
contextual-menu

@spylogsster spylogsster self-assigned this Jan 18, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 19, 2023
@stephendonner
Copy link

stephendonner commented Feb 13, 2023 •
edited
Loading

macOS has a separate issue here: #26825. Removing OS/macOS label.

@LaurenWags
Copy link
Member

marking as QA/Blocked until questions from https://bravesoftware.slack.com/archives/CKNHM4RTK/p1677768069627199 are resolved.

@LaurenWags
Copy link
Member

Updated labels and confirmed via above slack thread that this is a duplicate of #26825.

Since verification notes are under 26825, left that one to be included in release notes for 1.49.x milestone.

@rebron rebron added closed/duplicate Issue has already been reported and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 2, 2023
This was referenced Mar 3, 2023
Closed
Closed
@LaurenWags
Copy link
Member

Per additional discussion under above slack thread, logged 2 follow ups:

#28880
#28881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
closed/duplicate Issue has already been reported copy-clean-link OS/Desktop OS/macOS QA/No release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Add copy clean link to the macOS application menu bar brave/brave-core
7 participants
@fmarier @stephendonner @spylogsster @sangwoo108 @rebron @LaurenWags @brave-builds