Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open brave://welcome in guest windows #29012

Closed
spylogsster opened this issue Mar 13, 2023 · 1 comment · Fixed by brave/brave-core#17577
Closed

Do not open brave://welcome in guest windows #29012

spylogsster opened this issue Mar 13, 2023 · 1 comment · Fixed by brave/brave-core#17577

Comments

@spylogsster
Copy link

spylogsster commented Mar 13, 2023

Description

as requested in #28704 (comment) we need to disable brave://welcome in guest windows

Steps to Reproduce

  • Open guest window
  • Navigate to brave://welcome

Actual result:

  • It will be successfully opened

Expected result:

  • It will not be opened

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

stephendonner commented Mar 14, 2023

Verified PASSED using

Brave 1.51.33 Chromium: 111.0.5563.64 (Official Build) nightly (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Steps:

  1. installed 1.51.33
  2. launched Brave
  3. clicked on Open Guest Window
  4. loaded brave://welcome

Confirmed I saw This site can't be reached error message

Screen Shot 2023-03-14 at 1 50 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment