Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 114.0.5735.110 to Chromium 114.0.5735.133 #31023

Closed
emerick opened this issue Jun 13, 2023 · 5 comments · Fixed by brave/brave-core#18893
Closed

Upgrade from Chromium 114.0.5735.110 to Chromium 114.0.5735.133 #31023

emerick opened this issue Jun 13, 2023 · 5 comments · Fixed by brave/brave-core#18893
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.52.x - Release #5

Comments

@emerick
Copy link
Contributor

emerick commented Jun 13, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/114.0.5735.110..114.0.5735.133?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Jun 13, 2023
@emerick emerick added this to the 1.52.x - Release #5 milestone Jun 13, 2023
This was referenced Jun 13, 2023
Merged
Merged
@LaurenWags LaurenWags mentioned this issue Jun 13, 2023
Closed
@emerick emerick mentioned this issue Jun 13, 2023
Merged
25 tasks
@kjozwiak
Copy link
Member

The above requires 1.52.126 or higher for 1.52.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 10 Version 22H2 (Build 19045.2965)

image

@LaurenWags
Copy link
Member

LaurenWags commented Jun 14, 2023 •
edited
Loading

Verified with

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (x86_64)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | macOS Version 13.4 (Build 22F66)
Intel

Verified with

Brave	1.52.126 Chromium: 114.0.5735.133 (Official Build) (arm64) 
Revision	fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS	macOS Version 13.4 (Build 22F66)

M1

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Linux

Screenshot from 2023-06-14 09-17-38

@hffvld
Copy link
Contributor

hffvld commented Jun 14, 2023 •
edited
Loading

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 UPB3.230519.008 release-keys]
Brave build: 1.52.126
Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision: fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
1 2 3
1 2 3

@kjozwiak kjozwiak mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.52.x - Release #5
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 114.0.5735.110 to Chromium 114.0.5735.133 brave/brave-core
7 participants
@kjozwiak @emerick @LaurenWags @GeetaSarvadnya @mkarolin @MadhaviSeelam @hffvld