Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to bridge from ETH on Ethereum to SOL on Solana #40674

Closed
1 of 6 tasks
onyb opened this issue Aug 26, 2024 · 2 comments
Closed
1 of 6 tasks

Unable to bridge from ETH on Ethereum to SOL on Solana #40674

onyb opened this issue Aug 26, 2024 · 2 comments
Assignees
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Win64 QA/Yes release-notes/include

Comments

@onyb
Copy link
Member

onyb commented Aug 26, 2024

Description

X https://x.com/DarklionDZyshko/status/1828083040222163434

Transaction corresponding to a firm quote (for a ETH on Ethereum to SOL on Solana bridge) is successfully created, but the wallet panel crashes while trying to render the approval screen for it.

Steps to reproduce

  1. Go to Bridge
  2. Select ETH on Ethereum as the source asset
  3. Select SOL on Solana as the destination asset
  4. Enter some source amount in order to fetch an indicative quote

Actual result

Panel crashes on clicking "Review bridge".

Expected result

SafeSign panel screen shows up

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.153

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

Closing as the above was fixed via brave/brave-core#25327 which was uplifted into 1.69.x. The above requires 1.69.156 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.156 Chromium: 128.0.6613.85 (Official Build) (64-bit)
Revision 1d701f8c67ab98b8c562ddd0fa2dafc1305f8605
OS Windows 11 Version 23H2 (Build 22631.4037)
  • Verified steps from issue description
  • Verified no browser crash when trying review bridge ETH on Ethereum to SOL on Solana
40674.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

No branches or pull requests

9 participants
@kjozwiak @onyb @srirambv @Douglashdaniel and others