Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vimeo support (tip/panel) #4391

Closed
NejcZdovc opened this issue May 10, 2019 · 1 comment · Fixed by brave/brave-core#2247
Closed

Add Vimeo support (tip/panel) #4391

NejcZdovc opened this issue May 10, 2019 · 1 comment · Fixed by brave/brave-core#2247
Assignees

Comments

@NejcZdovc
Copy link
Contributor

In first phase we added support for AC for Vimeo (#4017). Now we would like to add support for panel/tip as well. Everything should behave in the same way as is for YT

@NejcZdovc NejcZdovc self-assigned this May 10, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 13, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 10, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2019

Verification passed on

Brave 0.68.104 Chromium: 75.0.3770.100 (Official Build) dev (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Screen Shot 2019-08-19 at 2 32 10 PM

Screen Shot 2019-08-19 at 2 32 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants