Failed to check for updates links needs to be redirected

[srirambv]

Description

Failed to check for updates links needs to be redirected

Steps to Reproduce

1. Build from source d3d5670
2. Open chrome://chrome from chrome://about
3. Shows error updating. Error code links to community page by just appending the code at the end of the URL. Learn more links to Google support page

Actual result:

Expected result:

Error code link should be specific link on community. Learn more should link to the same page

Reproduces how often:

100%

Brave version (about:brave info)

d3d5670 release build from source

Additional Information

cc: @bbondy @yrliou

[simonhong]

That html error message is made by below in UpdateCheckDriver::OnUpgradeError.

...
  base::string16 html_error_msg =
      base::StringPrintf(L"%d: <a href='%ls0x%X' target=_blank>0x%X</a>",
                         error_code_, base::UTF8ToUTF16(
                             chrome::kUpgradeHelpCenterBaseURL).c_str(),
                         hresult_, hresult_);
...
}

And learn more link is made by below in about_page.html.

                  <a hidden$="[[!shouldShowLearnMoreLink_(
                      currentUpdateStatusEvent_)]]" target="_blank"
                      href="https://support.google.com/chrome?p=update_error">
                    $i18n{learnMore}
                  </a>

[srirambv]

Happens when this message is received as well

[bbondy]

maybe wes hould just set shouldShowLearnMoreLink_ to false?

[simonhong]

@bbondy , what is preferred way? deleting all links or replacing all links with community.brave.com?

[bbondy]

I think replacing with community.brave.com. Please CC me on any PR for that though.
I think @Brave-Matt is working on getting real links for those.

[GeetaSarvadnya]

Validated the issue on:

Brave	0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision	9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS	Windows

[kjozwiak]

@bbondy checked that the clicking on the Learn more link correctly points to https://community.brave.com/?p=update_error when disconnecting the internet but is there another way to check the other error codes?

[bbondy]

not sure, but I think that's a good enough test.

[kjozwiak]

Thanks for the quick response 👍 Really appreciate it!

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X