Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields site settings are not included in the "site settings" counter #5225

Closed
fmarier opened this issue Jul 11, 2019 · 3 comments
Closed

Shields site settings are not included in the "site settings" counter #5225

fmarier opened this issue Jul 11, 2019 · 3 comments
Labels
closed/invalid feature/settings feature/shields The overall Shields feature in Brave.

Comments

@fmarier
Copy link
Member

fmarier commented Jul 11, 2019

Description

The number of sites shown under "Site Settings" in the Advanced tab of chrome://settings/clearBrowserData does not include any Shields override added by a user even though those will get cleared.

Steps to Reproduce

  1. Open chrome://settings/clearBrowserData and clear Site Settings in Advanced (All time).
  2. Open Slack and give it the permission to do desktop notifications.
  3. Open http://gs.statcounter.com/ and click on Shields Down.
  4. Visit chrome://settings/clearBrowserData.

Actual result:

1 site:

Screenshot from 2019-07-11 14-34-00

Expected result:

2 sites

Reproduces how often:

Perfectly reproducible.

Brave version (brave://version info)

Brave	0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision	cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS	Linux
@rebron
Copy link
Collaborator

rebron commented Jul 12, 2019

@tomlowenthal Should we have shield settings have its own listing here instead of bundling it with site settings?

@fmarier
Copy link
Member Author

fmarier commented Jul 12, 2019

Should we have shield settings have its own listing here instead of bundling it with site settings?

There's already a bug (from Tom) for that (#3926) and if we decided to do that then we wouldn't have to fix the incorrect count.

@tildelowengrimm
Copy link
Contributor

Closing this in favor of #3926. Let me know if that doesn't seem right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid feature/settings feature/shields The overall Shields feature in Brave.
Projects
None yet
Development

No branches or pull requests

3 participants