Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reddit tipping banner text alignment issue #5447

Closed
GeetaSarvadnya opened this issue Jul 30, 2019 · 4 comments
Closed

Reddit tipping banner text alignment issue #5447

GeetaSarvadnya opened this issue Jul 30, 2019 · 4 comments
Labels

Comments

@GeetaSarvadnya
Copy link

Description

Reddit tipping banner text alignment issue

Steps to Reproduce

  1. Open 0.68.113
  2. Open https://www.reddit.com/r/brave_browser/
  3. Click on inline Tip link on any Reddit post
  4. Content is not displayed completely in the post text field also a lot of empty space in Tip amount banner

Actual result:

Reddit tipping banner text alignment issue

image

the text iO... cuts off the banner in the post text field:

image

Expected result:

the post text field content should be wrapped in the tipping banner

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

seems similar to #4566

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2019

@NejcZdovc we should probably crop the banner when someone tips something large that might cause the above. Maybe implement a character limit of some type?

@NejcZdovc
Copy link
Contributor

yeah we should limit content height and just hide everything else

@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Sep 20, 2019
@NejcZdovc
Copy link
Contributor

closing as dupe of #4566

@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes bug priority/P4 Planned work. We expect to get to it "soon". labels Apr 10, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants