Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to select text in Shields Menu by double clicking the blocked scripts #5472

Closed
btlechowski opened this issue Jul 31, 2019 · 5 comments
Labels
closed/wontfix feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. QA/Test-Plan-Specified QA/Yes regression

Comments

@btlechowski
Copy link

btlechowski commented Jul 31, 2019

Follow up to #4570

Important: Not sure if it is by design or an actual issue

Steps to Reproduce

  1. Open https://www.buzzfeed.com
  2. Block the scripts in Shields
  3. Go to Scripts blocked detailed view
  4. Double click the blocked script

Actual result:

The script text is selected
5472

Expected result:

The script text is not selected

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Not reproducible in

Brave 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @cezaraugusto @karenkliu

@btlechowski btlechowski added feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified feature/shields/!scripts Blocking JavaScript with Shields regression feature/shields/panel Front-end design and functionality of the Shields panel. labels Jul 31, 2019
@ryanbr
Copy link

ryanbr commented Jul 31, 2019

I use Ctrl-A, Ctrl-C. is this possible in the new screen?

@btlechowski
Copy link
Author

@ryanbr This is about detailed view of Scripts blocked. This is not about detailed view of Cross-site trackers blocked. You can still copy list of trackers blocked from detailed view of Cross-site trackers blocked. The functionality didn't change there.

image

@ryanbr
Copy link

ryanbr commented Jul 31, 2019

Ah right

@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2019

It used to be the same behaviour before. May have regressed where you couldn't select it but now it's working correctly. You should be allowed to highlight the blocked URLs to see the actual link since shields only have limited visibility for the URLs'

@cezaraugusto
Copy link
Contributor

hi @btlechowski thanks for reporting. we intent to implement a copy/paste interface in the future but for now this is expected behavior. closing as wontfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. QA/Test-Plan-Specified QA/Yes regression
Projects
None yet
Development

No branches or pull requests

4 participants