Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslated text on connect hardware screen #6037

Closed
srirambv opened this issue Sep 16, 2019 · 7 comments
Closed

Untranslated text on connect hardware screen #6037

srirambv opened this issue Sep 16, 2019 · 7 comments

Comments

@srirambv
Copy link
Contributor

Description

Untranslated text on connect hardware screen

Steps to Reproduce

  1. Create cryptowallet account
  2. Go to profile and connect hardware
  3. Connect hardware screen has an untranslated text [object Object]

Actual result:

image

Expected result:

All text should be translated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@ryanml ryanml assigned ryanml and cg505 and unassigned ryanml and cg505 Sep 16, 2019
@ryanml
Copy link
Contributor

ryanml commented Sep 21, 2019

Awaiting deployment, fixed on dev:

Screen Shot 2019-09-21 at 1 59 43 PM

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 2, 2019
@ryanml
Copy link
Contributor

ryanml commented Oct 5, 2019

This is fixed on the latest release

@ryanml ryanml closed this as completed Oct 5, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

Verification PASSSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Used Crypto Wallets - Version: 1.0.9 for the following checks:

Screen Shot 2019-10-07 at 1 47 54 AM

Screen Shot 2019-10-07 at 1 47 49 AM

@kjozwiak kjozwiak added this to the 0.69.x - Release milestone Oct 7, 2019
@GeetaSarvadnya
Copy link

The issue is still reproducible in windows 10 x64 - 0.69.132

image

@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

@GeetaSarvadnya can you include the STR you used? Can't seem to reproduce on my Win 10 x64 machine.

@srirambv
Copy link
Contributor Author

srirambv commented Oct 7, 2019

Verification passed on

Brave 0.69.132 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Linux
  • Verified text is translated on Crypto Wallets - Version: 1.0.9
    image

@srirambv
Copy link
Contributor Author

srirambv commented Oct 7, 2019

Can't reproduce on Windows. Looks fixed on Crypto Wallets - Version: 1.0.9
image

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants