Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create or enable P3A UI for Android #6688

Closed
2 tasks
bbondy opened this issue Oct 31, 2019 · 3 comments
Closed
2 tasks

Create or enable P3A UI for Android #6688

bbondy opened this issue Oct 31, 2019 · 3 comments
Assignees
@karenkliu @deeppandya
Labels
closed/no-milestone features/P3A OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@bbondy
Copy link
Member

bbondy commented Oct 31, 2019 •
edited
Loading

Same as on desktop but for Android, we'll get the underlying functionality for free once we're on core.

We need:

  • To notify the user about it and tell them they can turn it off.
  • Add the option to turn it off.
@bbondy bbondy added the OS/Android Fixes related to Android browser functionality label Oct 31, 2019
@bsclifton
Copy link
Member

bsclifton commented Oct 31, 2019 •
edited
Loading

related #6176 and https://github.com/brave/browser-android-tabs/issues/2106

@anthonypkeane
Copy link

anthonypkeane commented Nov 6, 2019 •
edited
Loading

Existing users flow
This UI should be presented for all existing users. The UI can only be disabled via one of the two options.

Pressing the hardware back button shouldn’t close this UI.
p3a

New users flow
For new users, also show the above UI after onboarding.
The UI can only be disabled via one of the two option

Regarding the On|Off setting, in
Settings>Privacy please add

Anonymously report feature usage
Send completely private product analytics to Brave. This info only lets Brave estimate the overall usage of certain features.

checkbox for On|Off

Place this setting above "Do Not Track"

cc @bradleyrichter

Note: Anonymously report feature usage may be too long, we'll have to see it on the device to confirm.

@anthonypkeane anthonypkeane mentioned this issue Nov 12, 2019
Closed
@anthonypkeane anthonypkeane added this to the Android 1.6.x Release milestone Feb 13, 2020
@bsclifton bsclifton mentioned this issue Mar 5, 2020
Closed
@SergeyZhukovsky SergeyZhukovsky removed this from the Android 1.8.x Release milestone May 6, 2020
@bsclifton bsclifton mentioned this issue Nov 1, 2020
Closed
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 4, 2020
@bsclifton bsclifton mentioned this issue Jan 11, 2021
Closed
@deeppandya
Copy link

Closing this issue as we have covered it in #12723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karenkliu karenkliu

@deeppandya deeppandya

Labels
closed/no-milestone features/P3A OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jamesmudgett @bbondy @karenkliu @bsclifton @deeppandya @anthonypkeane @SergeyZhukovsky