Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards service should be disabled when switching off Rewards #6765

Closed
tmancey opened this issue Nov 4, 2019 · 1 comment
Closed

Rewards service should be disabled when switching off Rewards #6765

tmancey opened this issue Nov 4, 2019 · 1 comment
Labels
closed/invalid closed/not-actionable feature/rewards

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 4, 2019

Description

Rewards service should be disabled when switching off Rewards

Steps to Reproduce

  1. Enable Rewards
  2. Disable Rewards

Actual result:

Rewards service continues to run (see console logs)

Expected result:

Rewards service should stop running

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

Should work like ads service where the service starts/stops
@tmancey tmancey added the bug label Nov 4, 2019
@NejcZdovc NejcZdovc added perf priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed bug labels Nov 18, 2019
@NejcZdovc
Copy link
Contributor

closing as we will not have disable button anymore with #9130

@NejcZdovc NejcZdovc added closed/not-actionable and removed perf priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 10, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/invalid closed/not-actionable feature/rewards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bbondy @tmancey @NejcZdovc