Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization is not applied for NTP rewards widget in German locale #6866

Closed
GeetaSarvadnya opened this issue Nov 11, 2019 · 5 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019

Description

Found while testing #6821
Localization is not applied for NTP rewards widget in German locale. Verified Germany and France locales in both locales NTP rewards widget isn't localized, this issue could be there in other locales also.

Steps to Reproduce

  1. Set OS locale to Germany
  2. Clean profile 0.71.114
  3. Open an NTP
  4. Rewards widget in an NTP is not localized
  5. Click on the Dashboard settings icon in NTP
  6. Show Brave Rewards setting isn't localized

Actual result:

Localization is not applied for NTP rewards widget in German locale
image

image

image

Expected result:

Brave rewards widget should be localized

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.71.114 Chromium: 78.0.3904.97 (Offizieller Build) (64-Bit)
Überarbeitung 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
Betriebssystem Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @mandar-brave @rebron @mkarolin @bsclifton @brave/legacy_qa

@GeetaSarvadnya
Copy link
Author

Strings are not translated in Enable ads rewards widget

image

@btlechowski
Copy link

Same for Polish locale (PL)

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

@LaurenWags
Copy link
Member

Reproduced for Bulgaria as well:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)

NTP widget has partial translations
Screen Shot 2019-11-11 at 10 56 03
Screen Shot 2019-11-11 at 10 56 20
Screen Shot 2019-11-11 at 10 56 33

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 10, 2020
@rebron
Copy link
Collaborator

rebron commented Jan 22, 2020

cc: @mkarolin ping to double check on this one when translations are ordered/come in for 1.3 round.

@rebron rebron self-assigned this Jan 22, 2020
@btlechowski
Copy link

No longer reproducible

Brave 1.4.95 Chromium: 80.0.3987.122 (Official Build) (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 7 Service Pack 1 (Build 7601.24544)

German locale:
image
image
image

Bulgarian
image
image
image

@NejcZdovc NejcZdovc added closed/not-actionable and removed QA/Test-Plan-Specified QA/Yes bug l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Mar 6, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Mar 6, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants