Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar Buttons should be squarer #785

Closed
petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#391
Closed

Toolbar Buttons should be squarer #785

petemill opened this issue Aug 20, 2018 · 1 comment · Fixed by brave/brave-core#391
Assignees
@petemill
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

Circle -> Square, see design spec for specific detail.

image
@petemill petemill added the design A design change, especially one which needs input from the design team label Aug 20, 2018
@petemill petemill added this to the Releasable builds 0.55.x milestone Aug 20, 2018
@petemill petemill self-assigned this Aug 20, 2018
@petemill petemill mentioned this issue Sep 4, 2018
Merged
14 tasks
@srirambv srirambv added the QA/Yes label Sep 9, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 24, 2018 •
edited by kjozwiak
Loading

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • verified using the back navigation button on both white & dark themes
  • verified using the forward navigation button on both white & dark themes
  • verified using the refresh button on both white & dark themes
  • verified using the home button on both white & dark themes
  • verified using the bookmark button on both white & dark themes
  • verified using the current user button on both white & dark themes
  • verified using the hamburger menu button on both white & dark themes

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Toolbar Styles brave/brave-core
5 participants
@petemill @bbondy @kjozwiak @srirambv @btlechowski